Skip to content

config: Add lint C13 for _this call in config text#910

Merged
BrettMayson merged 2 commits intomainfrom
configThisCall
Mar 11, 2025
Merged

config: Add lint C13 for _this call in config text#910
BrettMayson merged 2 commits intomainfrom
configThisCall

Conversation

@PabstMirror
Copy link
Collaborator

requires the hints_and_notes change from #909

help[L-C13]: Unnecessary `_this` in `call`
   ┌─ addons/main/config.cpp:10:14
   │
10 │ statement = "_this call f;";
   │              ^^^^^^^^^^^^^
   │
   = note: `call` inherits `_this` from the calling scope
   = help: Remove `_this` from the call

@codecov
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 6.06061% with 93 lines in your changes missing coverage. Please review.

Project coverage is 67.2%. Comparing base (3cc1193) to head (5063645).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...s/config/src/analyze/lints/c13_config_this_call.rs 6.0% 93 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...s/config/src/analyze/lints/c13_config_this_call.rs 6.0% <6.0%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BrettMayson BrettMayson merged commit f09d773 into main Mar 11, 2025
35 of 37 checks passed
@BrettMayson BrettMayson deleted the configThisCall branch March 11, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants