Skip to content

Conversation

@Breus
Copy link
Owner

@Breus Breus commented Nov 5, 2025

No description provided.

@Breus Breus requested review from EmielBoss and Copilot November 5, 2025 19:27
@Breus Breus self-assigned this Nov 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Ingredient model by consolidating the separate name and quantity fields into a single description field. This simplification allows ingredients to be stored as free-form text (e.g., "200g Spaghetti") rather than structured data.

Key changes:

  • Merged name and quantity fields into a single description field across the full stack
  • Updated database schema and migration scripts to reflect the new structure
  • Modified UI components to use a single input field with enhanced placeholder text

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ui/src/models/domain/Ingredient.ts Changed TypeScript interface from name and quantity to single description field
ui/src/components/RecipeView.vue Updated template to display ingredient description instead of separate quantity and name
ui/src/components/CreateRecipe.vue Replaced two input fields with single description field and updated validation logic
app/src/main/resources/db/migration/V1.6__create_ingredient_table.sql Modified schema to use description column instead of name and quantity
app/src/main/resources/db/dev-data/V2.3__insert_ingredients.sql Updated seed data to use combined description format
app/src/main/java/dev/blaauwendraad/recipe_book/web/model/IngredientDto.java Changed DTO from two fields to single description field
app/src/main/java/dev/blaauwendraad/recipe_book/web/RecipeResource.java Updated mapping logic to use new description field
app/src/main/java/dev/blaauwendraad/recipe_book/service/model/Ingredient.java Changed domain model to single description field
app/src/main/java/dev/blaauwendraad/recipe_book/service/RecipeService.java Updated service layer mapping to use description
app/src/main/java/dev/blaauwendraad/recipe_book/repository/RecipeRepository.java Modified repository to persist single description field
app/src/main/java/dev/blaauwendraad/recipe_book/data/model/IngredientEntity.java Changed entity model from two fields to single description
app/src/main/java/dev/blaauwendraad/recipe_book/config/ReferenceDataSyncService.java Updated log message (incorrect change - should be "name" not "description")

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Test Results

5 tests  ±0   5 ✅ ±0   3s ⏱️ ±0s
3 suites ±0   0 💤 ±0 
3 files   ±0   0 ❌ ±0 

Results for commit 0342dd9. ± Comparison against base commit 582993e.

…ceDataSyncService.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Breus Breus merged commit 956010c into master Nov 9, 2025
1 check passed
@Breus Breus deleted the ingredient-revamp branch November 9, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant