Remove billing period fields from Workspace#42
Merged
BrewingCoder merged 8 commits intomainfrom Mar 20, 2026
Merged
Conversation
Dead SaaS billing code — HoldFast has no billing periods. Removes BillingPeriodStart, BillingPeriodEnd, NextInvoiceDate from Workspace model, resolver field mappings, and GraphQL schema. Simplifies getWorkspaceMeterImpl in pricing.go to always use current calendar month boundaries (the else-branch that was already the fallback). Removes billing period fields from test fixtures in worker_test.go and public-graph/resolver_test.go. Adds 5 unit test functions (30+ subtests) for pricing package: RetentionMultiplier, ProductToBasePriceCents, TypeToMemberLimit, MustUpgradeForClearbit, Worker no-ops. Regenerated GraphQL code via gqlgen. Closes #30 🤖 Agentic: submitted by Claude Code agent Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The merge took main's schema which re-added billing_period_end and next_invoice_date. Removed them again and regenerated. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Closing: needs rebase on top of gqlgen v0.17.88 upgrade (#51). Old generated code causes SIGBUS crashes. |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remediation for Go compiler crashes on 88K-line generated file: - Runner-2 disabled (single runner only) - Go build cache cleaned on runner - Go 1.25 already in go.mod (from gqlgen upgrade merge) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BillingPeriodStart,BillingPeriodEnd,NextInvoiceDatefrom Workspace modelbilling_period_endandnext_invoice_datefrom GraphQL Workspace typegetWorkspaceMeterImplinpricing.go— always uses current calendar month (no billing period logic)worker_test.goandpublic-graph/resolver_test.gogqlgenRetentionMultiplier,ProductToBasePriceCents,TypeToMemberLimit,MustUpgradeForClearbit, Worker no-opsCloses #30
Test plan
go build ./...passesgo test ./model/— 206 tests passgo test ./pricing/— all tests pass (including 30+ new subtests)gofmtclean🤖 Agentic: submitted autonomously by Claude Code agent
🤖 Generated with Claude Code