Generate rcxnub and rcxnub_odd from the assembly file#8
Merged
mesheets merged 4 commits intoBrickBot:masterfrom May 4, 2025
Merged
Generate rcxnub and rcxnub_odd from the assembly file#8mesheets merged 4 commits intoBrickBot:masterfrom
mesheets merged 4 commits intoBrickBot:masterfrom
Conversation
This is the source of the fastdl.srec file, written by Kekoa Proudfoot, downloaded from: http://www.mralligator.com/rcx/firmdl3.tar.gz
Contributor
Author
|
At some time, generated default parser and lexer should also be updated… or removed. |
Contributor
Author
|
Hum… I guess something is messing with my EOLs. |
Move one instruction to make it bit exact with the previously included SREC file, add conditional to also generate the odd parity version. The unused rcxnub_linuxusb.h and the commented out version in rcxnub_odd.h were the same. They explicitly set odd parity while the non commented version just skip changing the register. On build, if H8300 toolchain is not available, use a pre-built version. If toolchain is available, the pre-built version is checked to make sure it is up to date.
They are generated anyway at every build.
Member
|
This looks to be very thorough—thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move one instruction to make it bit exact with the previously included SREC
file, add conditional to also generate the odd parity version.
The unused rcxnub_linuxusb.h and the commented out version in rcxnub_odd.h
were the same. They explicitly set odd parity while the non commented version
just skip changing the register.
On build, if H8300 toolchain is not available, use a pre-built version. If
toolchain is available, the pre-built version is checked to make sure it is up
to date.
Also remove outdated pre-built rxc[12]_nqh.h. They are generated anyway at
every build.
For reference here is the disassembly of original srec file:
This one for nub_odd:
And this one is the commented part of nub_odd, which is identical to
nub_linuxusb:
They only differs for the parity regester write.