Made create-fabric work.#1
Merged
Brickmaster1 merged 1 commit intoBrickmaster1:version/1.20.1from Jan 10, 2026
Merged
Conversation
Brickmaster1
approved these changes
Jan 10, 2026
Owner
Brickmaster1
left a comment
Brickmaster1
left a comment
There was a problem hiding this comment.
Whoa dude! Thanks!! I kinda got frustrated and never fully finished this, so this is awesome! You clearly were able to resolve the part in the fluid system I started on, but could never properly figure out, even with Alpha's help.
I'll merge this and see if anything else needs to be done to fix gregtech with create fabric, or if it just runs, and if it works, I'll make a PR on mainline Kilt.
Author
|
GregTech doesn't seem to work yet unfortunately. If it helps, I noticed they seem to use their own custom FluidBuilder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to make create-fabric work by changing the priority of FluidInject so Porting Lib injects first. I also re-added the null fluidType check to ForgeFlowingFluid (I want to invoke super hence why I put it inside that class) and made a kilt version of the getVanillaFluidType function which avoids the StackOverFlowException.
I was going to pull request the NeoForge module into https://github.com/Brickmaster1/NeoForge as well, but for some reason your repository wouldn't show up in the pull request targets list so I'm afraid you'll just have to pull from https://github.com/Acuadragon100/NeoForge/tree/registrate-fluids manually.