Various GregTech fixes#2
Merged
Brickmaster1 merged 7 commits intoBrickmaster1:version/1.20.1from Feb 11, 2026
Merged
Conversation
All forge mods will assume it's a ForgeFlowingFluid anyway so we won't get any ClassCastExceptions from them. Only Fabric mods will expect SimpleFlowableFluid. We just have to make sure to avoid getting caught by Registrate.
Required to allow extracting potions from GT containers.
Acuadragon100
force-pushed
the
registrate-fluids-gt-fix
branch
from
7a12003 to
19c57bb
Compare
I just got rid of the amount and tag variables from the forge FluidStack and instead store them in the porting lib FluidStack directly. I also got rid of the isEmpty boolean since I think it only adds complexity for no good reason.
…pped. This should hopefully solve that weird random crash I had.
Acuadragon100
force-pushed
the
registrate-fluids-gt-fix
branch
from
19c57bb to
a3bdfd7
Compare
Owner
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at this again I realised that SimpleWrappedForgeFlowingFluid is actually not necessary. All forge mods will assume it's a ForgeFlowingFluid anyway so we won't get any ClassCastExceptions from them. Only Fabric mods will expect SimpleFlowableFluid. We just have to make sure to avoid getting caught by Registrate.
I also changed the priority of registering fabric storage providers to make extracting fluids into potions possible.
There are just 2 more issues I noticed while using this.1. My game would sometimes crash with the following error:It would happen once the first time when accessing an inventory, but only sometimes. Maybe caused by mod loading order?2. It doesn't look like the GT block entities save their state when modifying the amount of existing fluid. They also seem to leave an air fluidstack behind instead of emptying themselves properly. Not sure if those are separate issues.I managed to fix the second issue (see Brickmaster1/NeoForge#2).
I think I have also fixed the first issue now.