ensure < 6 levels of nesting scope #583

[moldover]

Refactor the offending chunks of code into functions.

[moldover]

Btw, I could add the inspection file .idea/inspectionProfilesProject_Default.xml which does this but it looks like @HEdingfield git-ignored the inspections config file. Was it causing problems with different versions or something?

[HEdingfield]

Hmm, I can't figure out which rule in there would exclude it. But, to answer your question, I think the idea was that our repo should be IDE-agnostic; we shouldn't assume that a developer is going to be using IntelliJ.

[moldover]

Hmm, I can't figure out which rule in there would exclude it. But, to answer your question, I think the idea was that our repo should be IDE-agnostic; we shouldn't assume that a developer is going to be using IntelliJ.

It's .idea/inspectionProfiles/Project_Default.xml so the rule .idea/**/Project_Default.xml hides it.

I agree that we don't want to force people to use intellij (and this won't change that) however this inspection profile is quite useful to us and the process needs to be preserved -- at least until something better is developed. Took me a couple hours to get it going, I'd hate to have that work repeated.

[tarheel]

I agree with @moldover -- if including this file is useful for anyone working in IntelliJ but it doesn't actually force a developer to use that IDE, then it's worth doing.