Initial validation highlighting#618
Merged
Merged
Conversation
… set of validation errors instead of an `isValid` boolean; fixes bug where `treatBlankAsUndeclaredWriteIn` validation failure for certain providers wouldn't fail validation.
…to `performBasicCvrSourceValidation` so user is alerted when clicking the "add" button in the CVR tab.
…ns for candidates and CVRs.
tarheel
reviewed
Aug 17, 2022
Contributor
tarheel
left a comment
tarheel
left a comment
There was a problem hiding this comment.
This is great! Could you post a screenshot or two?
| Logger.severe("If candidate codes are used, a unique code is required for each candidate!"); | ||
| } | ||
|
|
||
| if (getNumDeclaredCandidates() < 1) { |
Contributor
Author
There was a problem hiding this comment.
I'm kind of in favor of keeping it this way in case some magic cosmic ray hits a computer and it results in a negative value.
# Conflicts: # src/main/java/network/brightspots/rcv/ContestConfig.java # src/main/java/network/brightspots/rcv/TabulatorSession.java
HEdingfield
commented
Aug 17, 2022
Contributor
Author
HEdingfield
left a comment
HEdingfield
left a comment
There was a problem hiding this comment.
Great review, thank you!
Contributor
Author
|
Screenshot here: |
tarheel
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ContestConfig.validate()and associated methods to return a set of validation errors instead of anisValidboolean.treatBlankAsUndeclaredWriteInvalidation failure for certain providers wouldn't actually fail validation.performBasicCvrSourceValidationso user is alerted when clicking the "add" button in the CVR tab.First pass as outlined in #137 (comment).