Prevent invisible rendering of loading spinner#6596
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
dlockhart
reviewed
Feb 13, 2026
duncanuszkay-d2l
force-pushed
the
dunk.table-backdrop-hotfix
branch
from
3543f1c to
364f042
Compare
dlockhart
approved these changes
Feb 13, 2026
Member
dlockhart
left a comment
dlockhart
left a comment
There was a problem hiding this comment.
Let's get this in to fix the build and then I want to think about it a bit more.
Updating vdiff goldens for PR 6596
Updating vdiff goldens for PR 6596
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
🎉 This PR is included in version 3.219.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
dlockhart
pushed a commit
that referenced
this pull request
Feb 13, 2026
Co-authored-by: Duncan Uszkay <Duncan.Uszkay@D2L.com>
dlockhart
added a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered a bug in automated tests relating to the new table loading backdrop feature in which parts of the table were no longer interactive. It turned out to be related to the loading spinner rendering over top of the table even in the hiding state, which we missed due to it being invisible. This screenshot demonstrates how the element was overlaid over the table:
To get us back to stability ASAP, I've simply extended the styles of the
backdrop-loadingcomponent to reduce the width of thed2l-loading-spinner-wrapperas well as thed2l-loading-spinneritself.Functional Tests
The backdrop loading feature itself is also still functional:
Recording.2026-02-13.102745.mp4