[DO NOT MERGE] GAUD-9165 - Page Templates - Version 2#6875
Draft
svanherk wants to merge 3 commits into
Draft
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Contributor
Author
|
Relevant demos: |
svanherk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to be merged, and code is not in a state to be reviewed (although can be referenced for those curious). But opening a PR is an easy way to get a preview site for others to play around with scrolling behaviour between the two versions.
This version is the second attempt after Friday's meetings, based a bit on how GitHub's panels scroll. The
mainpanel usesbodyscroll, while the side panels have their own individual sticky behaviour.I also added a switch to demonstrate how it feels to be able to scroll the full nav away in the multi-panel view - Lessons doesn't currently do this, but could.