Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dbatiste
approved these changes
May 1, 2026
bearfriend
approved these changes
May 1, 2026
|
|
||
| #renderText() { | ||
| if (!this.text) return nothing; | ||
| const lines = this.text.split(/\r\n|\n/gi); |
Contributor
There was a problem hiding this comment.
Suggested change
| const lines = this.text.split(/\r\n|\n/gi); | |
| const lines = this.text.split(/\r?\n/g); |
Member
Author
There was a problem hiding this comment.
I'll do a follow-up with this.
|
🎉 This PR is included in version 3.240.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once newlines in lang terms are properly handled by OSLO, the process of going through BSI and being injected into the LMS database turns
\n(LF) into\r\n(CRLF).Technically splitting on
\nto create confirmation dialog paragraphs still works with\r\n, but handling both line endings feels cleaner.