GAUD-9165 - Example of how we could apply fix to our sticky components#6911
GAUD-9165 - Example of how we could apply fix to our sticky components#6911svanherk wants to merge 6 commits into
Conversation
…real, sticky componets with hardcoded z-indexes
There was a problem hiding this comment.
I don't know why collapsible-panel is set up this way, it's confusing. I think this is a good fix regardless, but maybe the vdiffs will disagree.
There was a problem hiding this comment.
Looks like mostly very subtle anti-aliasing changes -- but there are some issues with "inline" panels that are focused.
There was a problem hiding this comment.
Yeah not as bad as I thought, if we go this route we'll need to dig more. This change would align collapsible-panel to work how the list controls work - applying certain styles when it sticks, not suddenly deciding to make it sticky.
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
|
Closing in favour of #6942 |
2 participants
Example of what we need to do to fix all our sticky components with immersive-nav in a world with
bodyscroll. I haven't tested all this, just quickly applied it to the components in the demo pages to show how it can fix it. It's not perfect, because if these things were nested in another scrolling component, the consumer would need to know to set this variable back to--d2l-sticky-offsetat that level.But I haven't found a different way to cleanly do this with body scroll. Putting this up so others can experiment.