Updating vdiff goldens for PR 7007#7009
Merged
margaree merged 1 commit intoMay 22, 2026
Merged
Conversation
margaree
approved these changes
May 22, 2026
Contributor
margaree
left a comment
margaree
left a comment
There was a problem hiding this comment.
The changes related to internal-critical happened locally as well. I don't totally know why but I don't find them to be concerning.
margaree
merged commit f6dfd82
into
mpeacocke/dialog-confirm-fix-overflow-sizing
1 check passed
margaree
added a commit
that referenced
this pull request
May 22, 2026
* dialog-confirm: native: fix overflow edge cases * Updating vdiff goldens (#7009) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add comment on height css, remove max-height as it doesn't seem to actually be necessary --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the vdiff goldens for the changes in pull request #7007.
Please review the resulting report closely before merging to ensure the visual differences are expected.