GAUD-10062: expose waitForElem#993
Merged
Merged
Conversation
dlockhart
commented
May 21, 2026
| if (typeof update === 'object' && Promise.resolve(update) === update) { | ||
| await update; | ||
| if (awaitLoadingComplete && typeof elem.getLoadingComplete === 'function') { | ||
| await elem.getLoadingComplete(); |
Member
Author
There was a problem hiding this comment.
I've also flipped the order here. We first wait for getLoadingComplete and then we wait for updateComplete. The reasoning here is that almost always getLoadingComplete resolving is going to trigger some kind of state change, so we wait for updateComplete after that.
dlockhart
commented
May 21, 2026
| ``` | ||
|
|
||
| ### Accessibility Testing with aXe | ||
| ### Accessibility Testing with axe |
GZolla
approved these changes
May 21, 2026
bearfriend
reviewed
May 21, 2026
bearfriend
approved these changes
May 22, 2026
|
🎉 This PR is included in version 1.45.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In somewhat rare circumstances, changing a component's state can cause a totally different set of components within it to render. One example might be putting it into an error state. When this happens, awaiting
updateCompleteisn't often enough, as those new nested components might have language terms that need to load or they may need to do their own asynchronous work.To solve this, we expose
waitForElem-- which is already used internally by the originalfixturecall.