Skip to content

Making DPS a python package#331

Merged
kreczko merged 9 commits intoBristolTopGroup:masterfrom
kreczko:python-package
Oct 11, 2016
Merged

Making DPS a python package#331
kreczko merged 9 commits intoBristolTopGroup:masterfrom
kreczko:python-package

Conversation

@kreczko
Copy link
Copy Markdown
Member

@kreczko kreczko commented Sep 6, 2016

Summary

  • moved all code to dps folder
    • configdps.config
      • config.XSectionConfigdps.config.xsection.XSectionConfig
    • condordps.condor
    • examplesdps.examples
    • experimentaldps.experimental
    • legacydps.legacy
    • srcdps.analysis
    • toolsdps.utils
  • updated all (?) import statements and paths
    • needs testing (running the usual scripts)
      • implement ntp run dps where=local|DICE
  • added setup.py
    • added requirements
    • added to tests

MISC

I noticed that a few files (old scripts) are broken due to missing variables (fit_var_* and bin_edges) and marked them with the @BROKEN tag (grep -rI "@BROKEN" . to see them)

@kreczko kreczko added this to the 13 TeV proper milestone Sep 6, 2016
@kreczko kreczko force-pushed the python-package branch 3 times, most recently from 317f53e to c8ad1b8 Compare September 12, 2016 10:20
@kreczko kreczko changed the title Making DPS a python package [WIP] Making DPS a python package Sep 13, 2016
@kreczko
Copy link
Copy Markdown
Member Author

kreczko commented Sep 13, 2016

Based on the feedback, there are still a few things to do.
Most importantly it would be useful for testing to create an NTP branch where this PR is integrated.
i.e. ntp run dps where=local|DICE

@kreczko kreczko changed the title [WIP] Making DPS a python package Making DPS a python package Oct 11, 2016
@kreczko kreczko merged commit 34a11ab into BristolTopGroup:master Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant