Skip to content

Automatic binning#74

Merged
kreczko merged 10 commits intoBristolTopGroup:masterfrom
kreczko:data_representation
May 2, 2014
Merged

Automatic binning#74
kreczko merged 10 commits intoBristolTopGroup:masterfrom
kreczko:data_representation

Conversation

@kreczko
Copy link
Copy Markdown
Member

@kreczko kreczko commented Mar 31, 2014

Automatic binning

  • added helper functions (purity, stability) + unit tests for them
  • added main script (00_pick_bins.py) + tests

Reorganised tests

  • deleted obsoletes
  • merged tests that belong to one module

Other

  • updated binning plots (synchronised with AnalysisSoftware)
  • updated rootpy

This pull request is NOT ready to merge. We need to discuss the bug regarding the differences in purity, stability and N events between what is done in the script and what is done in the helper functions.

kreczko added 10 commits March 31, 2014 15:56
 - added helper functions (purity, stability) + unit tests for them
 - added main script (00_pick_bins.py) + tests

Reorganised tests
 - deleted obsoletes
 - merged tests that belong to one module
 - updated bin centre reweighting to match newest rootpy
 - removed if for 7 TeV, now everything is the same
 - added old p- & s-values for comparison
 - synchronised configs
 - removed 7 TeV specific paths (they are no longer valid) from fitting
 - added tables folder to gitignore
 - added library module for cross section measurement
 - added license
@kreczko
Copy link
Copy Markdown
Member Author

kreczko commented May 1, 2014

Ready for merging.
test/cross_section_measuremen_00_pick_bins.py is still failing, expecially the number of events requirement:

Traceback (most recent call last):
  File "test/cross_section_measuremen_00_pick_bins.py", line 176, in test_n_events
    self.assertGreaterEqual( N, self.n_min )
AssertionError: 384.0 not greater than or equal to 400

======================================================================
FAIL: test_n_events_reduced_spread (__main__.Test)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/cross_section_measuremen_00_pick_bins.py", line 186, in test_n_events_reduced_spread
    self.assertGreaterEqual( N, self.n_min )
AssertionError: 268.0 not greater than or equal to 400

This needs further investigation into how purity, stability and N-events are calculated using the two methods:

  1. When creating the new bins
  2. after re-binning with the new bins

Generally the numbers do not agree.

kreczko added a commit that referenced this pull request May 2, 2014
@kreczko kreczko merged commit 26ffed3 into BristolTopGroup:master May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant