Skip to content

Bugfixes for the new ROOT version#79

Merged
kreczko merged 2 commits intoBristolTopGroup:masterfrom
senkin:new_root_fix
May 9, 2014
Merged

Bugfixes for the new ROOT version#79
kreczko merged 2 commits intoBristolTopGroup:masterfrom
senkin:new_root_fix

Conversation

@senkin
Copy link
Copy Markdown
Member

@senkin senkin commented May 9, 2014

  • compiled the new ROOT version (5.34.18) using the 64bit virtual machine, in order to be used via travis;
  • added it to the travis matrix in .travis.yml
  • our current code shouldn't pass the code integration test as in the new root version TH2F.GetBinLowEdge method exits with error (which makes sense, as the axis needs to be specified);
  • in the next commit, this will be fixed.

@senkin
Copy link
Copy Markdown
Member Author

senkin commented May 9, 2014

As expected, Travis build failed with

ROOTError: level=3000, loc='TH2F::GetBinLowEdge', msg='Invalid method for a 2-d histogram - return a NaN'

kreczko added a commit that referenced this pull request May 9, 2014
Bugfixes for the new ROOT version
@kreczko kreczko merged commit b0f01bc into BristolTopGroup:master May 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants