Skip to content

Some final updates to ensure all scripts work and all files are named correctly after recent changes.#84

Merged
senkin merged 4 commits intoBristolTopGroup:masterfrom
jjacob:master
May 15, 2014
Merged

Some final updates to ensure all scripts work and all files are named correctly after recent changes.#84
senkin merged 4 commits intoBristolTopGroup:masterfrom
jjacob:master

Conversation

@jjacob
Copy link
Copy Markdown
Contributor

@jjacob jjacob commented May 14, 2014

  • Corrected naming of merged histogram files so that the measurement scripts can find and use them.
  • Updated the runnning scripts in bin/, including naming the output logs so that they can be accessed properly by the later scripts.
  • Small correction in what is output during the fit in tools/Fitting.py so that only what is necessary is printed out to the log file)
  • Updates to 98_fit_cross_checks.py matching the other recent changes New bins ++ #78 and Spring cleaning #81.

Comment thread bin/AN-14-071 Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not putting it into x_05_all_vars?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@senkin
Copy link
Copy Markdown
Member

senkin commented May 14, 2014

While you're here, could you also change this line to

control_region = 'TTbar_plus_X_analysis/MuPlusJets/QCD mu+jets PFRelIso ge3j/Muon/muon_pfIsolation_04_' + b_tag_b

?
That histogram directory was renamed recently, and this is the only place it appears apart from legacy scripts.

Comment thread tools/Fitting.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you removing the verbose output from fitting?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value for gMinuit.SetPrintLevel of -1 is the level required for the fit log file (to be used by the later 98_fit_cross_checks script). And so it became a pointless if statement since both conditions required a value of -1. I've described in the few lines above this point in the code what the values available are, and how much output they provide, so can be changed manually in future...just not with the verbose flag.

@jjacob
Copy link
Copy Markdown
Contributor Author

jjacob commented May 14, 2014

Added a new commit with modifications as per suggestions from Luke and Sergey. Also replied to comments in-line.

…les together.

Fixing some more file paths according to recent naming changes.
senkin added a commit that referenced this pull request May 15, 2014
Some final updates to ensure all scripts work and all files are named correctly after recent changes.
@senkin senkin merged commit f3d72d2 into BristolTopGroup:master May 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants