Merged
Conversation
Requests synthetic PDF log from Groundhog Web Viewer API
attachment response now 200
ximenesuk
reviewed
Apr 13, 2023
ximenesuk
reviewed
Apr 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
Started with 47e4298 but getting error |
This comment was marked as resolved.
This comment was marked as resolved.
ximenesuk
reviewed
Apr 19, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
|
I've updated the function and tests to handle cases where the upstream API is offline or returning a 500 error. In this case, we will also return a 500 with a helpful message. I'm happy for this to be merged now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests synthetic PDF log from Groundhog Web Viewer API (https://webservices.bgs.ac.uk/GWBV/viewborehole?loca_id=20200204094811691620) using BGS Loca ID.
Currently gets a 200 response but PDF doesn't display. Tried as both
inline&attachmentbut PDF files are only 1kb - it's not actually pulling the PDF from the web viewer.Addresses #100