Skip to content

ignore changes in package-lock.json file#48

Merged
zimlu02 merged 1 commit intoBroadcomMFD:masterfrom
grianbrcom:patch-2
Jan 3, 2022
Merged

ignore changes in package-lock.json file#48
zimlu02 merged 1 commit intoBroadcomMFD:masterfrom
grianbrcom:patch-2

Conversation

@grianbrcom
Copy link
Copy Markdown
Contributor

I believe, that this will fix your pipeline completely.
Here, how it works for me: https://github.com/grianbrcom/code4z/runs/4335640531?check_suite_focus=true
It fails for me because I don't have the credentials to publish the vsix package.

@michalbali256
Copy link
Copy Markdown
Collaborator

The last command has to be edited in order for this to be working properly.

Something along the lines:

    - name: Publish
      run: npx vsce publish
      env:
        VSCE_PAT: ${{ secrets.MARKETPLACE_PAT }}

However I do not have access to secrets in this repository so I am unable to check how is the Personal Access Token named or if it even exists.

Also, in order for the semantic release to work, future commits have to follow the conventional commits specification: https://www.conventionalcommits.org/en/v1.0.0/
That is also the reason why the git add command fails - the semantic-release run doesn't produce any changes, since there are no fix: or feat: commits.

@grianbrcom
Copy link
Copy Markdown
Contributor Author

I agree that the latest command must be fixed. But have no idea what we need to put here too.

But I use chore: prefix and this is a valid conventional commit format. git add can't fail because of the commit name.

@michalbali256
Copy link
Copy Markdown
Collaborator

We just need to find someone who has admin rights to this repo and find out what is the name of the secret/add it. Then the command I have written probably will work.

chore: does not cause the semantic release to up the version and produce changelog. If there are no changes in the repo, then the git add SHOULD fail - no changes to be commited and no new version to be released and published.

@zimlu02 zimlu02 merged commit a96a3ba into BroadcomMFD:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants