Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the calendar export functionality to generate more accurate and standards-compliant ICS files, with a particular focus on correct timezone handling for events. The changes ensure that exported calendar events use the "America/Toronto" timezone explicitly, include proper timezone definitions, and generate timestamps in the correct format for both local and UTC times.
ICS file format and timezone improvements:
ICS_TIMEZONEconstant and updated event start/end times to useTZID=America/Torontoand generate timestamps in the specified timezone, improving the accuracy of event times in exported calendars.Pink-ish color: new

Yellow: old (shifted forwards an hour or completely messed up with the 3 hour classes