Add Bubble visual effect#29
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
…size/color Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add bubble effect with configurable options
Add Bubble visual effect
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new Bubble effect: randomly-sized hollow bubble rings that rise from the bottom of the screen, with smooth fade in/out.
Effect properties
color— bubble ring color (default: light blue, semi-transparent)count— number of bubbles in the pattern (5–200, default20)speed— rise speed in screen heights/sec (default0.15)max_size— maximum bubble radius as a fraction of screen height (default0.06)length— resizable event duration in beatsImplementation notes
(x, y, radius)are generated once into a fixed array using a localSystem.Random. Each frame the entire pattern is scrolled byTime.time * speedwith modulo wrapping — no per-frame allocation or random generation.rx = ry / cam.aspectso rings appear circular at any resolution.Files changed
BopVisualEffects/Effects/Bubble/BubbleEffect.cs— new effect (definition + runner + overlay)BopVisualEffects/Core/EffectDefinitionRegistry.cs— registerBubbleEffectalphabetically firstdocs/effects/README.md— document properties; preview video placeholder left for in-game recordingOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.