Skip to content

Add Speed Lines visual effect#31

Open
Copilot wants to merge 5 commits into
masterfrom
copilot/add-speed-effect-triangles
Open

Add Speed Lines visual effect#31
Copilot wants to merge 5 commits into
masterfrom
copilot/add-speed-effect-triangles

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 18, 2026

  • Create BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs with IVisualEffectDefinition implementation and SpeedLinesRunner/SpeedLinesOverlay inner classes
  • Register SpeedLinesEffect in EffectDefinitionRegistry.cs (alphabetically between Sepia and Vertical Flip)
  • Add Speed Lines section to docs/effects/README.md (alphabetically between Sepia and Vertical Flip)
  • Fix speed property to use correct Hz → rad/s conversion (* 2π) in flicker sine
  • Fix build errors: remove using System;, use System.Action?, System.Random, System.Math.PI to match codebase conventions and resolve Random ambiguity
  • Fix spelling consistency: replace British English ("centre", "centred", "randomised") with American English ("center", "centered", "randomized") in comments
Original prompt

This section details on the original issue you should resolve

<issue_title>Speed effect</issue_title>
<issue_description>An effect where black, thin triangles coming from the edge of the screen towards the center show up and disappear to give a feeling of high speed.</issue_description>

Comments on the Issue (you are @copilot in this section)


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Copilot AI changed the title [WIP] Add speed effect with triangles animation Add Speed Lines visual effect Mar 18, 2026
Copilot AI requested a review from Brollyy March 18, 2026 06:04
@Brollyy Brollyy marked this pull request as ready for review March 18, 2026 06:32
Copilot AI review requested due to automatic review settings March 18, 2026 06:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Speed Lines visual effect to the BopVisualEffects mod, expanding the set of editor/runtime visual overlays with an animated “high-speed motion” screen-edge triangle burst.

Changes:

  • Introduces SpeedLinesEffect (template + scheduler + GL overlay runner) with alpha, count, and speed properties.
  • Registers the new effect in EffectDefinitionRegistry in alphabetical order.
  • Documents the effect in docs/effects/README.md (including the required preview placeholder).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/effects/README.md Adds documentation for the new “Speed Lines” effect and its properties/preview placeholder.
BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Implements the new effect definition, runner lifecycle, and GL-based overlay rendering.
BopVisualEffects/Core/EffectDefinitionRegistry.cs Registers SpeedLinesEffect so it appears in templates and runtime dispatch.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@Brollyy
Copy link
Copy Markdown
Owner

Brollyy commented Mar 18, 2026

Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 18, 2026

@copilot Build failed: https://github.com/Brollyy/BopVisualEffects/actions/runs/23231452082/job/67528183559?pr=31

Fixed in 0a753ee. Two build errors were resolved:

  1. CS0030 — replaced (Action?)SpawnAction with (System.Action?)SpawnAction to match codebase convention
  2. CS0104 — removed using System; and fully qualified System.Random and System.Math.PI to eliminate the ambiguity between System.Random and UnityEngine.Random

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new “Speed Lines” visual effect to the Bits & Bops editor mod, including runtime implementation, registration, and user-facing documentation.

Changes:

  • Added SpeedLinesEffect implementation with a runner + camera overlay that renders animated inward-pointing triangles.
  • Registered the new effect in EffectDefinitionRegistry in alphabetical order.
  • Documented the new effect (properties + preview placeholder) in docs/effects/README.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
docs/effects/README.md Adds the “Speed Lines” section with properties and preview placeholder.
BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Implements the new speed-lines effect, runner lifecycle, and GL overlay rendering.
BopVisualEffects/Core/EffectDefinitionRegistry.cs Registers SpeedLinesEffect and adds the namespace import.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
Comment thread BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs Outdated
@Brollyy
Copy link
Copy Markdown
Owner

Brollyy commented Mar 18, 2026

@copilot apply changes based on the comments in this thread

Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 18, 2026

@copilot apply changes based on the comments in this thread

Done in 03b095d — replaced all six British English spellings ("centre" → "center", "centred" → "centered", "randomised" → "randomized") in the comments of SpeedLinesEffect.cs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speed effect

3 participants