Add Speed Lines visual effect#31
Conversation
Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds a new Speed Lines visual effect to the BopVisualEffects mod, expanding the set of editor/runtime visual overlays with an animated “high-speed motion” screen-edge triangle burst.
Changes:
- Introduces
SpeedLinesEffect(template + scheduler + GL overlay runner) withalpha,count, andspeedproperties. - Registers the new effect in
EffectDefinitionRegistryin alphabetical order. - Documents the effect in
docs/effects/README.md(including the required preview placeholder).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/effects/README.md | Adds documentation for the new “Speed Lines” effect and its properties/preview placeholder. |
| BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs | Implements the new effect definition, runner lifecycle, and GL-based overlay rendering. |
| BopVisualEffects/Core/EffectDefinitionRegistry.cs | Registers SpeedLinesEffect so it appears in templates and runtime dispatch. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
@copilot Build failed: https://github.com/Brollyy/BopVisualEffects/actions/runs/23231452082/job/67528183559?pr=31 |
Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Fixed in 0a753ee. Two build errors were resolved:
|
There was a problem hiding this comment.
Pull request overview
Adds a new “Speed Lines” visual effect to the Bits & Bops editor mod, including runtime implementation, registration, and user-facing documentation.
Changes:
- Added
SpeedLinesEffectimplementation with a runner + camera overlay that renders animated inward-pointing triangles. - Registered the new effect in
EffectDefinitionRegistryin alphabetical order. - Documented the new effect (properties + preview placeholder) in
docs/effects/README.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
docs/effects/README.md |
Adds the “Speed Lines” section with properties and preview placeholder. |
BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cs |
Implements the new speed-lines effect, runner lifecycle, and GL overlay rendering. |
BopVisualEffects/Core/EffectDefinitionRegistry.cs |
Registers SpeedLinesEffect and adds the namespace import. |
You can also share your feedback on Copilot code review. Take the survey.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Brollyy <12004018+Brollyy@users.noreply.github.com>
Done in 03b095d — replaced all six British English spellings ("centre" → "center", "centred" → "centered", "randomised" → "randomized") in the comments of |
BopVisualEffects/Effects/SpeedLines/SpeedLinesEffect.cswithIVisualEffectDefinitionimplementation andSpeedLinesRunner/SpeedLinesOverlayinner classesSpeedLinesEffectinEffectDefinitionRegistry.cs(alphabetically between Sepia and Vertical Flip)docs/effects/README.md(alphabetically between Sepia and Vertical Flip)speedproperty to use correct Hz → rad/s conversion (* 2π) in flicker sineusing System;, useSystem.Action?,System.Random,System.Math.PIto match codebase conventions and resolveRandomambiguityOriginal prompt
📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.