Skip to content

Fix build issue #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tysonthomas9 merged 1 commit into from
Dec 7, 2025
Merged

Fix build issue #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions config/gni/devtools_grd_files.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ grd_files_bundled_sources = [
"front_end/Images/breakpoint-circle.svg",
"front_end/Images/breakpoint-crossed-filled.svg",
"front_end/Images/breakpoint-crossed.svg",
"front_end/Images/browser-operator-logo.png",
"front_end/Images/brush-2.svg",
"front_end/Images/brush-filled.svg",
"front_end/Images/brush.svg",
Expand Down Expand Up @@ -109,6 +110,7 @@ grd_files_bundled_sources = [
"front_end/Images/cssoverview_icons_2x.avif",
"front_end/Images/custom-typography.svg",
"front_end/Images/database.svg",
"front_end/Images/demo.gif",
"front_end/Images/deployed.svg",
"front_end/Images/device-fold.svg",
"front_end/Images/devices.svg",
Expand Down Expand Up @@ -656,6 +658,26 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/ui/SettingsDialog.js",
"front_end/panels/ai_chat/ui/OnboardingDialog.js",
"front_end/panels/ai_chat/ui/onboardingStyles.js",
"front_end/panels/ai_chat/ui/settings/types.js",
"front_end/panels/ai_chat/ui/settings/constants.js",
"front_end/panels/ai_chat/ui/settings/i18n-strings.js",
"front_end/panels/ai_chat/ui/settings/providerConfigs.js",
"front_end/panels/ai_chat/ui/settings/utils/validation.js",
"front_end/panels/ai_chat/ui/settings/utils/storage.js",
"front_end/panels/ai_chat/ui/settings/utils/styles.js",
"front_end/panels/ai_chat/ui/settings/components/ModelSelectorFactory.js",
"front_end/panels/ai_chat/ui/settings/components/SettingsHeader.js",
"front_end/panels/ai_chat/ui/settings/components/SettingsFooter.js",
"front_end/panels/ai_chat/ui/settings/components/AdvancedToggle.js",
"front_end/panels/ai_chat/ui/settings/providers/BaseProviderSettings.js",
"front_end/panels/ai_chat/ui/settings/providers/GenericProviderSettings.js",
"front_end/panels/ai_chat/ui/settings/providers/LiteLLMSettings.js",
"front_end/panels/ai_chat/ui/settings/providers/OpenRouterSettings.js",
"front_end/panels/ai_chat/ui/settings/advanced/MCPSettings.js",
"front_end/panels/ai_chat/ui/settings/advanced/BrowsingHistorySettings.js",
"front_end/panels/ai_chat/ui/settings/advanced/VectorDBSettings.js",
"front_end/panels/ai_chat/ui/settings/advanced/TracingSettings.js",
"front_end/panels/ai_chat/ui/settings/advanced/EvaluationSettings.js",
"front_end/panels/ai_chat/ui/mcp/MCPConnectionsDialog.js",
Comment on lines +661 to 681
Copy link

@coderabbitai coderabbitai bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

ai_chat GRD metadata still incomplete for some new TS sources

The newly added ai_chat JS entries here generally line up with the TS sources listed in front_end/panels/ai_chat/BUILD.gn and _ai_chat_sources, which is good for the release GRD check. However, a few new TS files now present in _ai_chat_sources still lack matching JS entries in grd_files_bundled_sources, which will likely keep the release build/GRD check failing:

Missing JS entries for TS files now in _ai_chat_sources:

  • Advanced settings:
    • ui/settings/advanced/MemorySettings.ts → front_end/panels/ai_chat/ui/settings/advanced/MemorySettings.js (not present near lines 676‑680).
  • UI conversation history & custom provider dialogs:
    • ui/ConversationHistoryList.ts → front_end/panels/ai_chat/ui/ConversationHistoryList.js
    • ui/conversationHistoryStyles.ts → front_end/panels/ai_chat/ui/conversationHistoryStyles.js
    • ui/CustomProviderDialog.ts → front_end/panels/ai_chat/ui/CustomProviderDialog.js
    • ui/customProviderStyles.ts → front_end/panels/ai_chat/ui/customProviderStyles.js
  • Persistence layer:
    • persistence/ConversationTypes.ts → front_end/panels/ai_chat/persistence/ConversationTypes.js
    • persistence/ConversationStorageManager.ts → front_end/panels/ai_chat/persistence/ConversationStorageManager.js
    • persistence/ConversationManager.ts → front_end/panels/ai_chat/persistence/ConversationManager.js

To keep the GRD lists consistent with _ai_chat_js_outputs_for_metadata, add these entries in the ai_chat block. For example:

@@
   "front_end/panels/ai_chat/ui/settings/advanced/VectorDBSettings.js",
   "front_end/panels/ai_chat/ui/settings/advanced/TracingSettings.js",
   "front_end/panels/ai_chat/ui/settings/advanced/EvaluationSettings.js",
+  "front_end/panels/ai_chat/ui/settings/advanced/MemorySettings.js",
   "front_end/panels/ai_chat/ui/mcp/MCPConnectionsDialog.js",
@@
   "front_end/panels/ai_chat/ui/WebAppCodeViewer.js",
   "front_end/panels/ai_chat/ui/TodoListDisplay.js",
   "front_end/panels/ai_chat/ui/FileListDisplay.js",
   "front_end/panels/ai_chat/ui/FileContentViewer.js",
+  "front_end/panels/ai_chat/ui/ConversationHistoryList.js",
+  "front_end/panels/ai_chat/ui/conversationHistoryStyles.js",
+  "front_end/panels/ai_chat/ui/CustomProviderDialog.js",
+  "front_end/panels/ai_chat/ui/customProviderStyles.js",
   "front_end/panels/ai_chat/core/AgentService.js",
@@
   "front_end/panels/ai_chat/core/structured_response.js",
   "front_end/panels/ai_chat/models/ChatTypes.js",
+  "front_end/panels/ai_chat/persistence/ConversationTypes.js",
+  "front_end/panels/ai_chat/persistence/ConversationStorageManager.js",
+  "front_end/panels/ai_chat/persistence/ConversationManager.js",
   "front_end/panels/ai_chat/ui/input/ChatInput.js",

This should align the GRD expectations with the JS outputs produced from the new TS files and fully fix the release build issue.

Also applies to: 709-709, 721-724, 734-734, 818-818, 828-837

🤖 Prompt for AI Agents 
In config/gni/devtools_grd_files.gni around lines 661 to 681 (and also check the
other reported ranges: 709, 721-724, 734, 818, 828-837), the ai_chat
grd_files_bundled_sources list is missing JS entries that correspond to newly
added TS sources in _ai_chat_sources; add the following JS entries to the
appropriate ai_chat block(s) so the GRD matches the JS outputs produced by the
build: front_end/panels/ai_chat/ui/settings/advanced/MemorySettings.js,
front_end/panels/ai_chat/ui/ConversationHistoryList.js,
front_end/panels/ai_chat/ui/conversationHistoryStyles.js,
front_end/panels/ai_chat/ui/CustomProviderDialog.js,
front_end/panels/ai_chat/ui/customProviderStyles.js,
front_end/panels/ai_chat/persistence/ConversationTypes.js,
front_end/panels/ai_chat/persistence/ConversationStorageManager.js, and
front_end/panels/ai_chat/persistence/ConversationManager.js; ensure each new
entry is placed in the same ordering/grouping as the existing ai_chat entries so
the GRD check and release build see the expected JS outputs.

"front_end/panels/ai_chat/ui/mcp/MCPConnectorsCatalogDialog.js",
"front_end/panels/ai_chat/ui/EvaluationDialog.js",
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Complete ai_chat GRD entries for new sources

devtools_grd_files.gni now enumerates the ai_chat UI files only up to FileContentViewer.js but omits the new modules added to _ai_chat_sources in front_end/panels/ai_chat/BUILD.gn (lines 292‑302) such as ConversationHistoryList, CustomProviderDialog, the conversation persistence classes, and MemorySettings. The release GRD check compares the generated JS from _ai_chat_sources against this list, so these omissions will continue to fail the release build and prevent those modules from being packaged.

Useful? React with 👍 / 👎.

Expand Down Expand Up @@ -684,6 +706,7 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/core/Version.js",
"front_end/panels/ai_chat/core/VersionChecker.js",
"front_end/panels/ai_chat/core/LLMConfigurationManager.js",
"front_end/panels/ai_chat/core/CustomProviderManager.js",
"front_end/panels/ai_chat/LLM/LLMTypes.js",
"front_end/panels/ai_chat/LLM/LLMProvider.js",
"front_end/panels/ai_chat/LLM/LLMProviderRegistry.js",
Expand All @@ -695,6 +718,10 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/LLM/GroqProvider.js",
"front_end/panels/ai_chat/LLM/OpenRouterProvider.js",
"front_end/panels/ai_chat/LLM/BrowserOperatorProvider.js",
"front_end/panels/ai_chat/LLM/CerebrasProvider.js",
"front_end/panels/ai_chat/LLM/AnthropicProvider.js",
"front_end/panels/ai_chat/LLM/GoogleAIProvider.js",
"front_end/panels/ai_chat/LLM/GenericOpenAIProvider.js",
"front_end/panels/ai_chat/LLM/LLMClient.js",
"front_end/panels/ai_chat/LLM/MessageSanitizer.js",
"front_end/panels/ai_chat/tools/Tools.js",
Expand All @@ -704,6 +731,7 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/tools/FetcherTool.js",
"front_end/panels/ai_chat/tools/FinalizeWithCritiqueTool.js",
"front_end/panels/ai_chat/tools/HTMLToMarkdownTool.js",
"front_end/panels/ai_chat/tools/ReadabilityExtractorTool.js",
"front_end/panels/ai_chat/tools/SchemaBasedExtractorTool.js",
"front_end/panels/ai_chat/tools/StreamlinedSchemaExtractorTool.js",
"front_end/panels/ai_chat/tools/VisitHistoryManager.js",
Expand Down Expand Up @@ -787,6 +815,7 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/evaluation/test-cases/schema-extractor-tests.js",
"front_end/panels/ai_chat/evaluation/test-cases/streamlined-schema-extractor-tests.js",
"front_end/panels/ai_chat/evaluation/test-cases/web-task-agent-tests.js",
"front_end/panels/ai_chat/evaluation/test-cases/html-to-markdown-tests.js",
"front_end/panels/ai_chat/evaluation/utils/ErrorHandlingUtils.js",
"front_end/panels/ai_chat/evaluation/utils/EvaluationTypes.js",
"front_end/panels/ai_chat/evaluation/utils/PromptTemplates.js",
Expand All @@ -796,6 +825,16 @@ grd_files_bundled_sources = [
"front_end/panels/ai_chat/mcp/MCPRegistry.js",
"front_end/panels/ai_chat/mcp/MCPToolAdapter.js",
"front_end/panels/ai_chat/mcp/MCPMetaTools.js",
"front_end/panels/ai_chat/memory/types.js",
"front_end/panels/ai_chat/memory/MemoryModule.js",
"front_end/panels/ai_chat/memory/MemoryBlockManager.js",
"front_end/panels/ai_chat/memory/MemoryAgentConfig.js",
"front_end/panels/ai_chat/memory/index.js",
"front_end/panels/ai_chat/memory/SearchMemoryTool.js",
"front_end/panels/ai_chat/memory/UpdateMemoryTool.js",
"front_end/panels/ai_chat/memory/ListMemoryBlocksTool.js",
"front_end/panels/ai_chat/utils/ContentChunker.js",
"front_end/panels/ai_chat/vendor/readability-source.js",
"front_end/panels/ai_chat/tools/LLMTracingWrapper.js",
"front_end/panels/animation/animation-meta.js",
"front_end/panels/animation/animation.js",
Expand Down
10 changes: 10 additions & 0 deletions front_end/panels/ai_chat/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,8 @@ _ai_chat_sources = [
"ui/HelpDialog.ts",
"ui/PromptEditDialog.ts",
"ui/SettingsDialog.ts",
"ui/OnboardingDialog.ts",
"ui/onboardingStyles.ts",
"ui/settings/types.ts",
"ui/settings/constants.ts",
"ui/settings/i18n-strings.ts",
Expand All @@ -281,15 +283,23 @@ _ai_chat_sources = [
"ui/settings/advanced/VectorDBSettings.ts",
"ui/settings/advanced/TracingSettings.ts",
"ui/settings/advanced/EvaluationSettings.ts",
"ui/settings/advanced/MemorySettings.ts",
"ui/EvaluationDialog.ts",
"ui/WebAppCodeViewer.ts",
"ui/TodoListDisplay.ts",
"ui/FileListDisplay.ts",
"ui/FileContentViewer.ts",
"ui/ConversationHistoryList.ts",
"ui/conversationHistoryStyles.ts",
"ui/CustomProviderDialog.ts",
"ui/customProviderStyles.ts",
"ui/mcp/MCPConnectionsDialog.ts",
"ui/mcp/MCPConnectorsCatalogDialog.ts",
"ai_chat_impl.ts",
"models/ChatTypes.ts",
"persistence/ConversationTypes.ts",
"persistence/ConversationStorageManager.ts",
"persistence/ConversationManager.ts",
"memory/types.ts",
"memory/MemoryModule.ts",
"memory/MemoryBlockManager.ts",
Expand Down
8 changes: 0 additions & 8 deletions front_end/panels/ai_chat/agent_framework/implementation/agents/ActionAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,14 +96,6 @@ Conclusion: Fix the args format and retry with proper syntax: { "method": "fill"
'node_ids_to_urls',
'scroll_page',
'take_screenshot',
'render_webapp',
'get_webapp_data',
'remove_webapp',
'create_file',
'update_file',
'delete_file',
'read_file',
'list_files',
],
maxIterations: 10,
modelName: MODEL_SENTINELS.USE_MINI,
Expand Down
3 changes: 0 additions & 3 deletions front_end/panels/ai_chat/agent_framework/implementation/agents/WebTaskAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,9 +204,6 @@ Remember: **Plan adaptively, execute systematically, validate continuously, and
'take_screenshot',
'wait_for_page_load',
'thinking',
'render_webapp',
'get_webapp_data',
'remove_webapp',
'create_file',
'update_file',
'delete_file',
Expand Down