Skip to content

Delete reference to sourcemap in socket.io.min#1230

Merged
shakyShane merged 1 commit intoBrowserSync:masterfrom
KenorFR:patch-1
Oct 13, 2016
Merged

Delete reference to sourcemap in socket.io.min#1230
shakyShane merged 1 commit intoBrowserSync:masterfrom
KenorFR:patch-1

Conversation

@KenorFR
Copy link
Copy Markdown
Contributor

@KenorFR KenorFR commented Oct 13, 2016

Delete "//# sourceMappingURL=socket.io.min.1.5.0.js.map"
The sourcemap file does not exist, the browser makes an error in the console.

OR It should be providing the sourcemap file

Delete "//# sourceMappingURL=socket.io.min.1.5.0.js.map" 
The sourcemap file does not exist, the browser makes an error in the console.

OR It should be providing the sourcemap file
@coveralls
Copy link
Copy Markdown

coveralls commented Oct 13, 2016

Coverage Status

Coverage remained the same at 97.055% when pulling 63c5b0a on KenorFR:patch-1 into f1238d2 on BrowserSync:master.

@shakyShane shakyShane merged commit 121c040 into BrowserSync:master Oct 13, 2016
@shakyShane
Copy link
Copy Markdown
Contributor

Thanks! We cannot use the sourcemap from socket.io as the script is modified at run time :)

You have also been invited to the Browsersync org (which means you'll full write access to all repos)

Please continue to submit PRs for code changes & be sure to review the guidelines. https://github.com/BrowserSync/browser-sync/blob/master/CONTRIBUTING.md#-submitting-a-pull-request

Any questions, just ask :)

@ghost
Copy link
Copy Markdown

ghost commented Oct 13, 2016

@shakyShane a new version will be tagged for this?

@shakyShane
Copy link
Copy Markdown
Contributor

@guilambert yes I will try to release later on today :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants