Delete reference to sourcemap in socket.io.min#1230
Merged
shakyShane merged 1 commit intoBrowserSync:masterfrom Oct 13, 2016
KenorFR:patch-1
Merged
Delete reference to sourcemap in socket.io.min#1230shakyShane merged 1 commit intoBrowserSync:masterfrom KenorFR:patch-1
shakyShane merged 1 commit intoBrowserSync:masterfrom
KenorFR:patch-1
Conversation
Delete "//# sourceMappingURL=socket.io.min.1.5.0.js.map" The sourcemap file does not exist, the browser makes an error in the console. OR It should be providing the sourcemap file
Contributor
|
Thanks! We cannot use the sourcemap from socket.io as the script is modified at run time :) You have also been invited to the Browsersync org (which means you'll full write access to all repos) Please continue to submit PRs for code changes & be sure to review the guidelines. https://github.com/BrowserSync/browser-sync/blob/master/CONTRIBUTING.md#-submitting-a-pull-request Any questions, just ask :) |
|
@shakyShane a new version will be tagged for this? |
Contributor
|
@guilambert yes I will try to release later on today :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete "//# sourceMappingURL=socket.io.min.1.5.0.js.map"
The sourcemap file does not exist, the browser makes an error in the console.
OR It should be providing the sourcemap file