Skip to content

Disable Nightly check for JPEG XL support#2936

Merged
MrAlex94 merged 1 commit intoBrowserWorks:currentfrom
louie-github:fix-jxl
Jan 11, 2023
Merged

Disable Nightly check for JPEG XL support#2936
MrAlex94 merged 1 commit intoBrowserWorks:currentfrom
louie-github:fix-jxl

Conversation

@louie-github
Copy link
Copy Markdown
Contributor

@louie-github louie-github commented Dec 21, 2022 •
edited
Loading

As mentioned in #2924, 4e1dca7 does not actually affect anything, because JPEG XL support is disabled in anything but Nightly builds.

Weirdly, the image.jxl.enabled config option is already set to true by default in 000-waterfox.js. This means that all Waterfox releases have broken JPEG XL support, since Firefox (and therefore Waterfox) sends the Accept: image/jxl header even if the JXL decoding support is not actually built and present.

This leads to issues such as missing pictures on Shopify-powered sites:

As a heads up, enabling JPEG XL support seems to break various websites in G5.1.1, for example MagicHolz. With enabled JPEG XL support (image.jxl.enabled set to true) various images on the website do not load anymore.

This should fix it by actually enabling JPEG XL support out-of-the box in all builds by removing the Nightly check.

Additionally, this test page by Jon Sneyers may prove useful: https://jpegxl.info/test-page/

@Demez Demez mentioned this pull request Dec 22, 2022
Merged
@MrAlex94 MrAlex94 merged commit 91c7e39 into BrowserWorks:current Jan 11, 2023
@MrAlex94
Copy link
Copy Markdown
Collaborator

MrAlex94 commented Jan 11, 2023

Thanks!

MrAlex94 pushed a commit that referenced this pull request Jan 16, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
75c013d
MrAlex94 pushed a commit that referenced this pull request Feb 17, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
6e3bf2e
davidmaxwaterman pushed a commit that referenced this pull request Mar 23, 2023
@louie-github @davidmaxwaterman
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
45227ab
MrAlex94 pushed a commit that referenced this pull request Apr 13, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
77ca5ab
MrAlex94 pushed a commit that referenced this pull request May 4, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
abcb5b5
MrAlex94 pushed a commit that referenced this pull request May 6, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
41b9019
MrAlex94 pushed a commit that referenced this pull request May 9, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
a524bb3
MrAlex94 pushed a commit that referenced this pull request May 9, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
3e2d7ea
MrAlex94 pushed a commit that referenced this pull request May 9, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
534285f
MrAlex94 pushed a commit that referenced this pull request May 11, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
1706a49
MrAlex94 pushed a commit that referenced this pull request May 12, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
d1aa036
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
a8df1f1
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
5a8495c
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
62f3766
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
ccb8ae1
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
52d7657
MrAlex94 pushed a commit that referenced this pull request May 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
c18ce03
MrAlex94 pushed a commit that referenced this pull request Jun 4, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
d9da65e
MrAlex94 pushed a commit that referenced this pull request Jun 5, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
d0dee8a
MrAlex94 pushed a commit that referenced this pull request Jun 5, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
eb8f790
MrAlex94 pushed a commit that referenced this pull request Jun 5, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
25f01a0
MrAlex94 pushed a commit that referenced this pull request Jun 5, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
20ef05e
MrAlex94 pushed a commit that referenced this pull request Jul 3, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
eb87700
MrAlex94 pushed a commit that referenced this pull request Jul 3, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
9ca2a44
MrAlex94 pushed a commit that referenced this pull request Jul 31, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
3f36f9f
MrAlex94 pushed a commit that referenced this pull request Aug 8, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
3ada5b6
MrAlex94 pushed a commit that referenced this pull request Nov 20, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
3e1db72
MrAlex94 pushed a commit that referenced this pull request Nov 20, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
6b35f36
MrAlex94 pushed a commit that referenced this pull request Nov 20, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
7121c35
MrAlex94 pushed a commit that referenced this pull request Dec 19, 2023
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
0f9ab47
MrAlex94 pushed a commit that referenced this pull request Jan 22, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
d576b7a
MrAlex94 pushed a commit that referenced this pull request Feb 14, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
00f476f
MrAlex94 pushed a commit that referenced this pull request Feb 19, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
f00fbcf
MrAlex94 pushed a commit that referenced this pull request Mar 19, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
f854e3e
MrAlex94 pushed a commit that referenced this pull request Mar 24, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
5235efe
MrAlex94 pushed a commit that referenced this pull request Apr 16, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
f378713
MrAlex94 pushed a commit that referenced this pull request May 13, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
b47aea2
MrAlex94 pushed a commit that referenced this pull request Jun 11, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
c6fdcad
MrAlex94 pushed a commit that referenced this pull request Jul 2, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
b38f794
MrAlex94 pushed a commit that referenced this pull request Aug 6, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
798c48c
MrAlex94 pushed a commit that referenced this pull request Aug 12, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
5a4bd85
MrAlex94 pushed a commit that referenced this pull request Aug 30, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
99ed6c8
MrAlex94 pushed a commit that referenced this pull request Sep 3, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
388e400
MrAlex94 pushed a commit that referenced this pull request Sep 23, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
a381707
MrAlex94 pushed a commit that referenced this pull request Sep 30, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
f7b568a
MrAlex94 pushed a commit that referenced this pull request Oct 8, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
06ba799
MrAlex94 pushed a commit that referenced this pull request Oct 10, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
8cc8185
MrAlex94 pushed a commit that referenced this pull request Oct 10, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
70ce0e2
MrAlex94 pushed a commit that referenced this pull request Oct 15, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
35e149a
MrAlex94 pushed a commit that referenced this pull request Oct 28, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
48eb70d
MrAlex94 pushed a commit that referenced this pull request Nov 4, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
e05c79a
MrAlex94 pushed a commit that referenced this pull request Nov 5, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
57a3439
MrAlex94 pushed a commit that referenced this pull request Nov 8, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
0687641
MrAlex94 pushed a commit that referenced this pull request Nov 25, 2024
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
ef2551e
MrAlex94 pushed a commit that referenced this pull request Jan 6, 2025
@louie-github @MrAlex94
[WFX-631] Disable Nightly check for JPEG XL support (#2936)
046c7d9
@DieselTech DieselTech mentioned this pull request Feb 14, 2026
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@louie-github @MrAlex94