Conversation
|
The App Store is a JS script since all its features can be implemented as a JS script without increasing firmware size. |
|
@emericklaw Hello, i think the same with the Apps section |
|
You still going to add in the mouse jacker middle man stuff from the other pull? |
|
@dabassman28 Hello, mousejack already exist on this beta version, try flashing my version and u will see |
|
@wcd6 Yeah I have seen the mouse jack function in the dev. I meant specifically the sniffer/ middleman function that I saw in your other pull from a few days ago. Wondered if you were still going to add that to the main dev branch via a pull. I didn't see it here. |
|
@dabassman28 I will gonna see it |
|
Nice looking forward to it |
|
Review this PR, thanks. |
|
@wcd6 please remove the App Store changes from this PR. If it even gets implemeted on device then I already have a verion locally. This also allows for much faster roll out of changes to the App Store without having to do a whole Bruce release. |
|
@emericklaw Was removed. |
|
Technical Review: NRF24 & RF Jammer Optimizations First, thank you for the PR - I can see you've put significant work into expanding features and improving the UI. However, I have some concerns about the implementation approach that I'd like to discuss before this gets merged. Overview I previously worked on optimizing both jammers for efficiency and real-world effectiveness. While your PR adds valuable features (turbo flooding, expanded channel lists, better UI), I'm concerned that some changes may actually reduce effectiveness while increasing resource usage. RF Jammer (rf_jammer.cpp) Issues Current Implementation (my previous work) - Efficient Approach: · Microsecond-precise timing with intelligent glitching patterns PR Changes - Concerns:
Recommendation for RF Jammer: Consider keeping the core jamming algorithms from the existing implementation and only merging: · The improved UI structure NRF24 Jammer (nrf_jammer.cpp) - Critical Hardware Constraints This is where I have the most significant concerns. The NRF24L01+ has hardware limitations that your implementation doesn't account for:
The NRF24L01+ has a 3-packet TX FIFO (96 bytes max). Your turbo flooding attempts: With burstCount=20, you're trying to push 20 packets through a 3-packet FIFO. This causes: · Constant SPI bus saturation
Each writeFast() involves multiple SPI transactions. With burstCount=20 across 125 channels, you're doing 2,500 writeFast() calls per sweep - this will likely saturate the SPI bus and cause the module to become unresponsive.
The current code respects FIFO limits:
While expanded channel lists are good (USB: 3→20, Video: 3→33, RC: 4→20), they need to be paired with realistic timing. More channels ≠ better jamming if you can't cover them effectively.
Adding TFT updates every 200ms during jamming will cause timing jitter and may interrupt critical TX timing. Specific Recommendations For NRF24 Jammer:
For RF Jammer:
Bottom Line Your PR adds great features (turbo flooding concept, expanded channel lists, better UI), but the implementation needs to respect hardware limitations. The existing code was simpler but hardware-appropriate. Your code is more feature-rich but risks: · Saturating the SPI bus I'd be happy to help test if you adjust the implementation to respect these hardware constraints. The features are valuable - they just need to be paired with hardware-aware execution. Note: I'm not a maintainer, but since I previously worked on optimizing these modules, I wanted to share my findings to help ensure this PR improves rather than degrades performance. |
Proposed Changes
This PR ports several UI/UX improvements from firmware-1.14 and adds major NRF24/RF jammer enhancements:
Ported from my changes in 1.14:
priColor) instead of hardcodedTFT_GREEN.drawMainBorderWithTitle,printSubtitle,padprintln, andprintFootnoteinstead of raw TFT calls. Replaced fixeddelay(7000)withAnyKeyPresswait.NRF24 Jammer Improvements (new):
RF Jammer Improvements (new):
Others
Types of Changes
Verification
lilygo-t-embed-cc1101and verify:Testing
Manual testing (lilygo-t-embed-cc1101).
Linked Issues
NONE
User-Facing Change
Further Comments