New Engine Feature: Add companion opcodes for op248/op249#6
Open
4Luke4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for two new effect types (opcodes
410and411) that trigger custom.EFFfiles when a melee or ranged attack misses.New Missed Attack Effects Functionality:
op410) and "miss ranged" (op411) effects, including:ExStatDatato store these effects, with associated management functions for copying, destroying, and transferring effects.GetMissMeleeEffectCount,GetMissMeleeEffect,GetMissRangedEffectCount, andGetMissRangedEffect, exposed in headers and bindings.Opcode_Hook_ApplyMissMeleeEffects,Opcode_Hook_ApplyMissRangedEffects).Integration with Effect Application and Stat Management:
op248andop249hooks to support the new miss effect types, ensuring effects are properly transferred and managed.OnDestruct,OnReload,OnEqu,OnPlusEqu) to correctly copy, destroy, and transfer miss effects during stat changes.See also: Bubb13/EEex#121.