Skip to content

Improve denied url messaging#18321

Merged
adrinr merged 4 commits intomasterfrom
improve-denied-url-messaging
Mar 18, 2026
Merged

Improve denied url messaging#18321
adrinr merged 4 commits intomasterfrom
improve-denied-url-messaging

Conversation

@adrinr
Copy link
Member

@adrinr adrinr commented Mar 17, 2026

Description

Improve denied url messaging and handling of blacklist urls in dev

Launchcontrol

Improve denied url messaging


Summary by cubic

Improves denied URL messaging and aligns blacklist handling across environments. Error now reads “URL is blocked or could not be resolved safely.” and dev uses the BLACKLIST_IPS override instead of an implicit bypass.

  • Bug Fixes
    • Enforce blacklist in all environments; removed dev-only bypass.
    • Set BLACKLIST_IPS: "" in scripts/dev/manage.js so localhost works in dev via explicit override.
    • Updated error message and tests; removed obsolete dev-bypass test.

Written for commit 2b44ad8. Summary will update on new commits.

@adrinr adrinr requested a review from a team as a code owner March 17, 2026 16:13
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Mar 17, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@adrinr adrinr requested a review from calexiou March 17, 2026 16:43
Copy link
Contributor

@deanhannigan deanhannigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr enabled auto-merge March 18, 2026 09:42
@adrinr adrinr merged commit 41e0335 into master Mar 18, 2026
32 checks passed
@adrinr adrinr deleted the improve-denied-url-messaging branch March 18, 2026 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

firestorm Data/Infra/Revenue Team size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants