This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Add relative ly lq support #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiomik
force-pushed
the
add-relative-ly-lq-support
branch
from
9afacd2 to
0a5f288
Compare
akiomik
force-pushed
the
add-relative-ly-lq-support
branch
5 times, most recently
from
20fbe6a to
37f24a7
Compare
akiomik
commented
Dec 22, 2021
Comment on lines
-25
to
41
| ): YearQuarter { | ||
| if (period.isLatestYear()) { | ||
| period.year = this.company['latest_fiscal_year'] | ||
| if (period.year instanceof LyWithOffset) { | ||
| period.year = this.company['latest_fiscal_year'] + period.year.offset | ||
| } | ||
|
|
||
| if (period.isLatestQuarter()) { | ||
| period.quarter = this.company['latest_fiscal_quarter'] | ||
| if (period.quarter instanceof LqWithOffset) { | ||
| period.year = | ||
| (period.year as number) + Math.ceil(period.quarter.offset / 4) | ||
| period.quarter = | ||
| this.company['latest_fiscal_quarter'] + (period.quarter.offset % 4) | ||
|
|
||
| if (period.quarter <= 0) { | ||
| period.year -= 1 | ||
| period.quarter = 4 + (period.quarter as number) | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
相対値を含むLY・LQを、 /api/v*/company のレスポンスを元に実際のFY・FQに変換するロジックです。
akiomik
force-pushed
the
add-relative-ly-lq-support
branch
from
37f24a7 to
8742a39
Compare
akiomik
force-pushed
the
add-relative-ly-lq-support
branch
from
8742a39 to
60af13e
Compare
Contributor
Author
|
conflictがあったのでrebaseしました |
Merged
shoe116
approved these changes
Dec 24, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下の対応を行いました。
LY-1LQ-1のような相対値のサポート (v2, v3)