This repository was archived by the owner on Sep 27, 2023. It is now read-only.
Fix latest param #77
Merged
Fix latest param #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akiomik
commented
Jan 8, 2022
| } | ||
|
|
||
| static parse(str: string): DateParam | YearQuarterParam { | ||
| str = str.toUpperCase() |
Contributor
Author
There was a problem hiding this comment.
各parserがそれぞれ必要な形式に変換しているのでここでの正規化は不要
Contributor
There was a problem hiding this comment.
ナイス これあると(結果戻してたとしても)だいぶごちゃごちゃして見えるから助かる
akiomik
force-pushed
the
fix-latest-param
branch
from
a34dde3 to
23b78c0
Compare
akiomik
commented
Jan 8, 2022
Comment on lines
-20
to
+18
| const date = DateParam.parse(str) | ||
| if (!date.isLatest()) { | ||
| return date | ||
| } | ||
| return DateParam.parse(str) |
Contributor
Author
There was a problem hiding this comment.
バグ修正の本体です。 latest のときの結果を無視するようにしていた処理を消しました。
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.