Skip to content

fix(examples): my-react-crasher fails to load#6

Merged
bobbyg603 merged 2 commits into
BugSplat-Git:mainfrom
zzmrl:main
Sep 7, 2022
Merged

fix(examples): my-react-crasher fails to load#6
bobbyg603 merged 2 commits into
BugSplat-Git:mainfrom
zzmrl:main

Conversation

@zzmrl
Copy link
Copy Markdown
Contributor

@zzmrl zzmrl commented Sep 7, 2022

Description

Here are changes to fix my-react-crasher base url when uploading to github pages. We wanted this url change only when deploying to pages, so I created a script called build:pages that will adjust the base url by calling vite with an alternate mode.

Fixes #5

Checklist

  • Tested manually
  • Unit tests pass with no errors or warnings
  • Documentation updated (if applicable)
  • Reviewed by at least 1 other contributor

Copy link
Copy Markdown
Member

@bobbyg603 bobbyg603 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@bobbyg603 bobbyg603 merged commit 16386b8 into BugSplat-Git:main Sep 7, 2022
github-actions Bot pushed a commit that referenced this pull request Sep 7, 2022
## [1.0.2](v1.0.1...v1.0.2) (2022-09-07)

### Bug Fixes

* **examples:** my-react-crasher fails to load ([#6](#6)) ([16386b8](16386b8))
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 7, 2022

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample Fails to Load at BugSplat-Git.github.io

2 participants