Conversation
…o.lock in npm files Co-authored-by: bobbyg603 <2646053+bobbyg603@users.noreply.github.com> Agent-Logs-Url: https://github.com/BugSplat-Git/node-dump-syms/sessions/51be9dc9-71e8-498c-bdb3-64e6816fa145
Copilot
AI
changed the title
[WIP] Fix build failure due to goblin version conflict in dump_syms 2.3.7
Fix build-from-source failure: pin dump_syms to =2.3.4, ship Cargo.lock in npm package
Mar 26, 2026
bobbyg603
approved these changes
Mar 26, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses build-from-source failures in node-dump-syms by preventing Cargo from resolving to a known-bad dump_syms release (which triggers a transitive goblin version conflict) and by ensuring the npm package includes the Rust lockfile for reproducible dependency resolution.
Changes:
- Pin Rust dependency
dump_symsto an exact known-good version (=2.3.4). - Include
Cargo.lockin the npm packagefileslist so from-source builds use the intended lockfile.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Cargo.toml |
Pins dump_syms to =2.3.4 to avoid the broken release and prevent semver drift. |
package.json |
Ships Cargo.lock in the published npm package for reproducible Cargo resolution during fallback builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
splatyourbugs
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dump_syms@2.3.7has a transitive goblin crate version conflict (0.8.2vs0.10.5) that causes compilation to fail. BecauseCargo.lockwas excluded from the npmfileslist, fresh from-source builds (fallback-to-build path) resolved to2.3.7instead of the locked2.3.4.Changes
Cargo.toml: Tightendump_symsfrom the open range"2.3.1"to exact pin"=2.3.4"— the last known-good version before the broken2.3.7package.json: AddCargo.locktofilesso the npm package ships the lock file, ensuring reproducible dependency resolution for from-source buildsOriginal prompt
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.