Readme #62
Merged
Readme #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzimovS
reviewed
Aug 16, 2025
Collaborator
There was a problem hiding this comment.
Thank you and @swellander for the efforts! The README is really good, I left some some comments
UPD: I noticed later that I am free to make commits. I add fixes for the obvious things and left some comments for the discussion
Collaborator
|
Oh, I just noticed that I am free to commit, will do it later |
AzimovS
reviewed
Aug 16, 2025
swellander
reviewed
Aug 16, 2025
Collaborator
|
For some reason, my changes that I committed earlier were reverted, pushed again |
AzimovS
approved these changes
Aug 19, 2025
Collaborator
AzimovS
left a comment
AzimovS
left a comment
There was a problem hiding this comment.
LTGM! Thank you very much for changes!🙏
…nd adjust checkpoint numbering; add note on unstaking in StakingOracle contract
escottalexander
force-pushed
the
readme
branch
from
a03593f to
4e9c50c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know we talked about using notion but the lack of support for native markdown makes it really difficult to work with.
Feel free to add commits with any obvious changes or raise questions about anything I have done here. Lot's of credit to the first steps that @swellander made.
I went ahead and changed the whitelist oracle to have the onlyOwner modifier commented out so that we avoid having to tell the user to update the deploy file. Since we are making the same compromise in the SimpleOracle I figured it made more sense to be consistent + make it easier.