Conversation
mas-iota
commented
Sep 3, 2023
| ); | ||
| }; | ||
|
|
||
| saveSampleAiData = (state, type) => { |
Contributor
Author
There was a problem hiding this comment.
reset? true | false
Function name -> onSaveAIData
Investigate if we can import the state parameters pass folders/images from that state, {images, folders}
| if ((images && images.length) || (folders && folders.length) ) { | ||
| this.setState(() => ({ images, folders, originalState, loaded: true })); | ||
| } | ||
| else |
Contributor
Author
There was a problem hiding this comment.
guard the else with brackets
|
|
||
| /** UTILS */ | ||
| const checkImageUrl = (url) => { | ||
| const optimisedURL = url.replace('1080x720', '300x300'); |
| const xhr = new XMLHttpRequest(); | ||
| xhr.open("GET", optimisedURL); | ||
| xhr.onerror = (error) => { | ||
| console.error('provided URL is not a valid image', error); |
Contributor
Author
There was a problem hiding this comment.
Not necessary, console.warn
| }; | ||
|
|
||
| /** UTILS */ | ||
| const checkImageUrl = (url) => { |
Contributor
Author
There was a problem hiding this comment.
elimanateNotFoundImages()
| let processedImages = items.map( | ||
| ({ naturalWidth, naturalHeight, originalSrc }) => { | ||
| return new Img({ | ||
| src: originalSrc, |
Contributor
Author
There was a problem hiding this comment.
use the fetched URLs
| }); | ||
| } | ||
|
|
||
| Promise.all(promises).then(items => { |
Contributor
Author
There was a problem hiding this comment.
Promise.allSettled()
| + 'Weather:https://source.unsplash.com/featured/?rainy\n' | ||
| + 'City:https://source.unsplash.com/featured/?street', | ||
| systemMessage: 'Each row contains a folder and image URL that should belong to. if nothing provided or no URLs provided then return null', | ||
| maxRecords: 10, |
Contributor
There was a problem hiding this comment.
I've made it 5 after testing, it's the most stable choice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.