fix(intro search): handle user position in the intro search#43
Merged
fix(intro search): handle user position in the intro search#43
Conversation
handle user position in the intro screen, and use initial view only in the map view, and add category empty state
enhance code complexity and remove disable from filter when there're some categories
handle city search in the ontro screen
minimize intro screen search code block
set location state upon centering map
don't change location search point when search area is disabled
mas-iota
requested changes
Sep 24, 2024
| margin-left: -15px; | ||
| margin-right: -15px; | ||
| margin-top: 18px; | ||
| height: 32px; |
Contributor
There was a problem hiding this comment.
line-height for the text element is better
| userPosition: null, | ||
| selectedLocation: null, | ||
| currentLocation: null, | ||
| mapCenterPosition: null, |
Contributor
There was a problem hiding this comment.
getter function is better
| import constants from "../../js/constants"; | ||
|
|
||
| const SearchLocationsModes = { | ||
| export const SearchLocationsModes = { |
use getter function to get map center point, and move all constants to a separate file
remove empty categories margin
getting locations with no location permissions, and fix breadcrumb issues
revert widget breadcrumb fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle user position in the intro screen, and use initial view only in the map view, and add category empty state