Skip to content

Enhancement#31

Merged
mas-iota merged 14 commits intoBuildFire:masterfrom
ibrahemomari:enhancement
Oct 18, 2023
Merged

Enhancement#31
mas-iota merged 14 commits intoBuildFire:masterfrom
ibrahemomari:enhancement

Conversation

@ibrahemomari
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread build.sh Outdated
@@ -0,0 +1 @@
cd .. && rm -rf mediaPlayerPlugin.zip && zip -r mediaPlayerPlugin.zip mediaPlayerPlugin/ -x "*/.*" -x "*/build.sh" -x "*/node_modules/*" -x "*/coverage/*" -x "*/test/*"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More findings is required.

Comment thread widget/app.js Outdated
});
}]);

const forceHideNavbar = function () {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for a function

Comment thread widget/app.js Outdated
};
}])
.run(['$rootScope',function ($rootScope) {
forceHideNavbar();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one $rootScope

Comment thread widget/assets/css/widget.app.css Outdated
width:auto;
max-width: 100%;
max-height: 100%;
width: 100%;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Indentation for the whole file

Comment thread widget/app.js Outdated
.run(['$rootScope',function ($rootScope) {
buildfire.language.get({ stringKey: 'general.PlaybackSpeedTitle' }, (err, result) => {
if (err) return console.error('Error while retrieving string value', err);
$rootScope.PlaybackSpeedTitle = result;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find a cleaner way

Comment thread resources/languages.json Outdated
"general": {
"title": "General",
"labels": {
"PlaybackSpeedTitle": {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to camelCase

* progress bar style
* @param {Number} value
*/
WidgetHome.progressBarStyle = function (value) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename updateProgressBarStyle

@mas-iota mas-iota merged commit 74a0cdd into BuildFire:master Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants