White screen#225
Merged
charkhaw merged 12 commits intoBuildFire:white-screen-offline-download-playlist-fixfrom Mar 5, 2023
Merged
White screen#225charkhaw merged 12 commits intoBuildFire:white-screen-offline-download-playlist-fixfrom
charkhaw merged 12 commits intoBuildFire:white-screen-offline-download-playlist-fixfrom
Conversation
Contributor
AlaaN-Smadi
commented
Mar 2, 2023
AlaaN-Smadi
commented
- fix the white screen in IOS
- fix play playlist audio
- fix download audio on IOS
…nualEntries into whiteScreen
charkhaw
changed the base branch from
master
to
white-screen-offline-download-playlist-fix
charkhaw
suggested changes
Mar 2, 2023
| } | ||
| if (res) { | ||
| res = res.filter(item=>(!(item.mediaType==='audio' && (item.originalMediaUrl.includes("www.dropbox") || item.originalMediaUrl.includes("dl.dropbox")) && !item.dropboxAudioUpdated))) | ||
| res = res.filter(item=>(!(item.mediaType==='audio' && (item.originalMediaUrl.includes("www.dropbox") || item.originalMediaUrl.includes("dl.dropbox")) && !item.dropboxAudioUpdatedV2))) |
Contributor
There was a problem hiding this comment.
- Keep the old settings
- just add new one
audioDownloadUpdatedas new filter condition under this block
res.filter(item=>( // ios and fileType audio)
charkhaw
approved these changes
Mar 5, 2023
charkhaw
merged commit 49e4f5b
into
BuildFire:white-screen-offline-download-playlist-fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.