refactor(mail): extract gmail query builder + concurrent agent updates#535
Merged
refactor(mail): extract gmail query builder + concurrent agent updates#535
Conversation
✅ Deploy Preview for agent-native-starter canceled.
|
This comment has been minimized.
This comment has been minimized.
…e RLS debug script
![builder-io-integration[bot]](https://avatars.githubusercontent.com/in/353721?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
✅ Deploy Preview for agent-native-scheduling ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-native-voice ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-native-meeting-notes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-native-design ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
… chat-running broadcast on send
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Code Review Summary — PR #535 (Final Incremental Update)
Reviewed latest 2 new commits. All code remains production-ready with no issues detected.
Latest Changes (New Commits)
Design Template:
- ✅ New
export-coding-handoffaction for creating tokenized handoff URLs for external agents - ✅ Access control: Uses
assertAccess("design", id, "viewer")to validate access - ✅ Security: Generates short-lived tokens (7-day TTL via
signShortLivedToken) - ✅ Proper error handling: Throws if design has no files to hand off
- ✅ Marked
readOnly: true(no mutations)
Slides Template (Index.tsx):
- ✅ Design system selection UI in new deck prompt with proper filtering
- ✅ useEffect dependencies now correctly scoped to
defaultSystem?.id+designSystems.length - ✅ Agent context expanded with design system guidance when deck is linked
Code Quality:
- ✅ No unscoped database queries
- ✅ Proper access control validation
- ✅ Type-safe schema usage
- ✅ All previously reviewed patterns maintained
Summary of Full PR
Mail Template:
- Gmail query builder extraction (correct logic, comprehensive tests)
- External refresh signal for cache bypass
- Event listener debouncing with proper cleanup
Slides Template:
- Generation state management (pure functions, well-tested)
- Design system deck linking (proper access control)
- Agent work indicator component (event-driven, clean lifecycle)
- Improved new deck UX with design system selection
Core Framework:
- Chat running event broadcasting (both true and false transitions)
- Agent work tracking available globally
Design Template:
- New coding handoff export action for external agent integration
Risk Assessment
Standard Risk — All changes:
- Are additive (no breaking changes)
- Have proper access control
- Include comprehensive test coverage
- Follow established patterns
- No database mutations issues
No blocking issues. PR is ready to merge pending CI validation.
🧪 Browser testing: Skipped — dev server infrastructure unavailable. Code is low-risk refactoring and feature enhancements with unit tests.
✅ Deploy Preview for nutritrack-daily-calories canceled.
|
✅ Deploy Preview for agent-native-dispatch canceled.
|
✅ Deploy Preview for agent-native-calendar canceled.
|
✅ Deploy Preview for agent-native-issues canceled.
|
✅ Deploy Preview for agent-native-macros canceled.
|
✅ Deploy Preview for agent-native-slides canceled.
|
✅ Deploy Preview for agent-native-recruiting canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildGmailQueryinto sharedserver/lib/gmail-query.tswith unit testsTest plan