Skip to content

EDU-548: Custom components - Child blocks - Nextjs 14#3980

Merged
uttej-vsk merged 13 commits intoBuilderIO:mainfrom
uttej-vsk:custom-components-nextjs
Mar 25, 2025
Merged

EDU-548: Custom components - Child blocks - Nextjs 14#3980
uttej-vsk merged 13 commits intoBuilderIO:mainfrom
uttej-vsk:custom-components-nextjs

Conversation

@uttej-vsk
Copy link
Contributor

@uttej-vsk uttej-vsk commented Mar 20, 2025

Description

This is the final leg of adding code to GitHub for the custom components—child blocks as per the ticket EDU-548 and its parent EDU-133.

Whats changed in this PR compared to other PRs?
I had to define builderComponents and set it true in the the component registration file like this:

shouldReceiveBuilderProps: { builderBlock: true, builderComponents: true },

Then, i passed builderComonents as a prop to the <blocks/> to resolve Hydration error that i have reported and on the browser, i got an error: Text component is not registered.

Acceptance criteria:

  • - Made sure there were no unnecessary conditional checks in the code.
  • - Verified that no unused types and types are not required.
  • - Confirmed that the code runs locally and passes all test cases without errors.
  • - Checked for any linting errors.
  • - Made sure no dead code that does not add value to users goes into PR, ensuring that its removal won’t impact overall functionality.
  • - Adding react-sdk-next-pages code to the PR.

@changeset-bot
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 9b19bfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gitguardian
Copy link

gitguardian bot commented Mar 20, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11707119 Triggered Generic High Entropy Secret 2c880f9 packages/sdks/snippets/sveltekit/src/routes/editable-region/+page.svelte View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nx-cloud
Copy link

nx-cloud bot commented Mar 20, 2025

View your CI Pipeline Execution ↗ for commit 3dc413d.

Command Status Duration Result
nx test @e2e/qwik-city ✅ Succeeded 8m 7s View ↗
nx test @e2e/nextjs-sdk-next-app ✅ Succeeded 7m 59s View ↗
nx test @e2e/nuxt ✅ Succeeded 7m 40s View ↗
nx test @e2e/gen1-next15-app ✅ Succeeded 5m 49s View ↗
nx test @e2e/angular-16-ssr ✅ Succeeded 6m 27s View ↗
nx test @e2e/angular-16 ✅ Succeeded 6m 17s View ↗
nx test @e2e/react-sdk-next-14-app ✅ Succeeded 5m 37s View ↗
nx test @e2e/react-sdk-next-15-app ✅ Succeeded 5m 49s View ↗
Additional runs (36) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-03-25 19:03:15 UTC

@uttej-vsk uttej-vsk changed the title EDU-548: Custom components - Child blocks - Nextjs EDU-548: Custom components - Child blocks - Nextjs 14 Mar 20, 2025
@uttej-vsk uttej-vsk marked this pull request as ready for review March 22, 2025 00:18
@uttej-vsk uttej-vsk removed the request for review from samijaber March 24, 2025 17:34
Copy link
Contributor

@sidmohanty11 sidmohanty11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left some minor comments

@uttej-vsk uttej-vsk merged commit 64905fb into BuilderIO:main Mar 25, 2025
46 checks passed
murrayadam pushed a commit to murrayadam/builder that referenced this pull request Sep 5, 2025
## Description

This is the final leg of adding code to GitHub for the custom
components—child blocks as per the ticket
[EDU-548](https://builder-io.atlassian.net/browse/EDU-548) and its
parent [EDU-133](https://builder-io.atlassian.net/browse/EDU-133).

Whats changed in this PR compared to other PRs?
I had to define `builderComponents` and set it `true` in the the
component registration file like this:

> shouldReceiveBuilderProps: { builderBlock: true, builderComponents:
true },

Then, i passed `builderComonents` as a prop to the `<blocks/>` to
resolve Hydration error that i have reported and on the browser, i got
an error: `Text component is not registered`.




**Acceptance criteria:**

- [x] - Made sure there were no unnecessary conditional checks in the
code.
- [x] - Verified that no unused types and types are not required.
- [x] - Confirmed that the code runs locally and passes all test cases
without errors.
- [x] - Checked for any linting errors.
- [x] - Made sure no dead code that does not add value to users goes
into PR, ensuring that its removal won’t impact overall functionality.
- [x] - Adding `react-sdk-next-pages` code to the PR.

[EDU-548]:
https://builder-io.atlassian.net/browse/EDU-548?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[EDU-133]:
https://builder-io.atlassian.net/browse/EDU-133?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants