EDU-548: Custom components - Child blocks - Nextjs 14#3980
EDU-548: Custom components - Child blocks - Nextjs 14#3980uttej-vsk merged 13 commits intoBuilderIO:mainfrom
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11707119 | Triggered | Generic High Entropy Secret | 2c880f9 | packages/sdks/snippets/sveltekit/src/routes/editable-region/+page.svelte | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
View your CI Pipeline Execution ↗ for commit 3dc413d.
☁️ Nx Cloud last updated this comment at |
packages/sdks/snippets/react-sdk-next-14-app/app/components/CustomColumns.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-14-app/app/advanced-child/page.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-14-app/app/custom-child/page.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-14-app/app/editable-region/page.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-14-app/app/custom-child/page.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-pages/src/pages/advanced-child/[[...page]].tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-pages/src/pages/custom-child/[[...page]].tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-pages/src/pages/editable-region/[[...page]].tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-pages/src/components/CustomTabs.tsx
Outdated
Show resolved
Hide resolved
packages/sdks/snippets/react-sdk-next-14-app/app/components/CustomTabs.tsx
Outdated
Show resolved
Hide resolved
sidmohanty11
left a comment
There was a problem hiding this comment.
LGTM, just left some minor comments
packages/sdks/snippets/react-sdk-next-14-app/app/components/CustomTabs.tsx
Outdated
Show resolved
Hide resolved
## Description This is the final leg of adding code to GitHub for the custom components—child blocks as per the ticket [EDU-548](https://builder-io.atlassian.net/browse/EDU-548) and its parent [EDU-133](https://builder-io.atlassian.net/browse/EDU-133). Whats changed in this PR compared to other PRs? I had to define `builderComponents` and set it `true` in the the component registration file like this: > shouldReceiveBuilderProps: { builderBlock: true, builderComponents: true }, Then, i passed `builderComonents` as a prop to the `<blocks/>` to resolve Hydration error that i have reported and on the browser, i got an error: `Text component is not registered`. **Acceptance criteria:** - [x] - Made sure there were no unnecessary conditional checks in the code. - [x] - Verified that no unused types and types are not required. - [x] - Confirmed that the code runs locally and passes all test cases without errors. - [x] - Checked for any linting errors. - [x] - Made sure no dead code that does not add value to users goes into PR, ensuring that its removal won’t impact overall functionality. - [x] - Adding `react-sdk-next-pages` code to the PR. [EDU-548]: https://builder-io.atlassian.net/browse/EDU-548?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [EDU-133]: https://builder-io.atlassian.net/browse/EDU-133?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Description
This is the final leg of adding code to GitHub for the custom components—child blocks as per the ticket EDU-548 and its parent EDU-133.
Whats changed in this PR compared to other PRs?
I had to define
builderComponentsand set ittruein the the component registration file like this:Then, i passed
builderComonentsas a prop to the<blocks/>to resolve Hydration error that i have reported and on the browser, i got an error:Text component is not registered.Acceptance criteria:
react-sdk-next-pagescode to the PR.