Skip to content

works with 2.3, 2.4, 3.0.0-pr1#15

Merged
nllong merged 1 commit intoBuildingSync:bender-updatesfrom
JoelBender:develop
Mar 31, 2022
Merged

works with 2.3, 2.4, 3.0.0-pr1#15
nllong merged 1 commit intoBuildingSync:bender-updatesfrom
JoelBender:develop

Conversation

@nllong
Copy link
Copy Markdown
Member

@nllong nllong commented Nov 29, 2021

No description provided.

Comment thread bsyncpy/bsync.py
@@ -16325,7 +16327,17 @@ class HVACSystemType(BSElement):

# BuildingType
class BuildingType(BSElement):
Copy link
Copy Markdown
Member Author

@nllong nllong Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoelBender -- What version of BSync.py is this attached to, I'm guessing v3.0.0-pr1, is that right?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is correct. A while ago Cory mentioned that it would be beneficial to have the version number in the module someplace along with the XML document that it builds, I'm not quite sure how I would do that.

Copy link
Copy Markdown
Member Author

@nllong nllong Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, thanks! Yes, it would be great to figure out how to handle specific versions but for now we can handle it based on the release versions. I think I'm going to point this one to develop-v3 in order to delineate the BSync 2.x and 3.x work.

And cherry pick the relevant comments to current develop (BSync 2.x support).

@nllong nllong changed the base branch from develop to bender-updates March 31, 2022 15:58
@nllong nllong merged commit d867ca5 into BuildingSync:bender-updates Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants