Use PyPi version of BSyncPy and Update to BuildingSync 2.4#412
Merged
nllong merged 2 commits intodevelop-v2from Nov 4, 2021
Merged
Use PyPi version of BSyncPy and Update to BuildingSync 2.4#412nllong merged 2 commits intodevelop-v2from
nllong merged 2 commits intodevelop-v2from
Conversation
Member
Author
|
DO NOT MERGE until pointing the poetry file to a pypi release of this package. |
nllong
commented
Nov 1, 2021
nllong
commented
Nov 1, 2021
| @@ -2,6 +2,7 @@ | |||
| "cells": [ | |||
Member
Author
There was a problem hiding this comment.
There are many changes to this file, easiest to view in Code/Browser.
macintoshpie
approved these changes
Nov 2, 2021
Contributor
macintoshpie
left a comment
macintoshpie
left a comment
There was a problem hiding this comment.
Just ran through the notebook in the browser and it all looks good
nllong
changed the title
nllong
changed the title
nllong
changed the title
nllong
commented
Nov 4, 2021
Member
Author
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
@macintoshpie -- can you check this again before I merge?
macintoshpie
approved these changes
Nov 4, 2021
| python = "^3.7.9" | ||
| jupyterlab = "^3.0.10" | ||
| bsyncpy = {git = "https://github.com/BuildingSync/bsyncpy.git", branch="feat/support-bsync-2.4" } | ||
| bsyncpy = "0.2.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The Jupyter notebook example was on version 2.3.
What does this PR do?
How should this be manually tested?
What are the relevant tickets?
#411
Screenshots (if appropriate)