refactor: allow versions without PATCH included#421
Merged
macintoshpie merged 2 commits intodevelop-v2from Dec 3, 2021
Merged
Conversation
macintoshpie
added
Non-breaking Change
Schema: General
macintoshpie
requested review from
JieXiong9119,
Ryoken,
markborkum and
nllong
markborkum
approved these changes
Nov 18, 2021
Contributor
markborkum
left a comment
markborkum
left a comment
There was a problem hiding this comment.
Changes look good, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
The root BuildingSync element has an
@versionattribute allowing users to specify the version of their document. We have been writing the full version,MAJOR.MINOR.PATCH, as the choices. This is not compatible with creating patch releases though -- since thex.x.0version was already released, it will consider any new patch version to be invalid according to that schema.MAJOR.MINORversions!What does this PR do?
MAJOR.MINORversions when specifying versions (but allow the old MAJOR.MINOR.PATCH to stick around)How should this be manually tested?
What are the relevant tickets?
#414
Screenshots (if appropriate)