Rename reference element#423
Conversation
Make the following reference elements global: `HeatingPlantID` `LinkedDeliveryIDs`
JieXiong9119
added
enhancement
Schema: Measures
macintoshpie
left a comment
macintoshpie
left a comment
There was a problem hiding this comment.
This is awesome - so well documented! Great job!
I just had a few questions, and also was wondering if you could add some of the v2 id's to our translator test files so we know the v2->v3 translator is working?
Yes I forgot to update that. Thanks for noticing! |
|
Lots of updates on the translators and test examples! |
macintoshpie
left a comment
macintoshpie
left a comment
There was a problem hiding this comment.
Looks great! I ran the translators locally and it seems to be working well.
I had just a few questions, but if they're actually non-issues then I think this is good to go!
| # schema_doc = Nokogiri::XML(URI.open('https://raw.githubusercontent.com/BuildingSync/schema/v2.4.0/BuildingSync.xsd')) | ||
| BUILDINGSYNC_V2_PATH = 'BuildingSync-v2.4.0.xsd' | ||
| if !File.file?(BUILDINGSYNC_V2_PATH) then | ||
| open(BUILDINGSYNC_V2_PATH, 'wb') do |file| | ||
| file << open('https://raw.githubusercontent.com/BuildingSync/schema/v2.3.0/BuildingSync.xsd').read | ||
| file << open('https://raw.githubusercontent.com/BuildingSync/schema/v2.4.0/BuildingSync.xsd').read |
| <VentilationControlMethod>Scheduled</VentilationControlMethod> | ||
| </VentilationControlMethods> | ||
| <auc:MakeupAirSpaceID xmlns:auc="http://buildingsync.net/schemas/bedes-auc/2019">Zone22</auc:MakeupAirSpaceID> | ||
| <MakeupAirSpaceID IDref="Zone22"/> |
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
Few questions, but overall this is looking great!
markborkum
left a comment
markborkum
left a comment
There was a problem hiding this comment.
Changes look good, thanks.
The only breaking change for Audit Template tool would be the renaming of the auc:SourceHeatingPlantID element.
4 participants
Any background context you want to provide?
See proposal.
What does this PR do?
Rename
IDREFelement as suggested in Docs/generic linking elements #415 :AlternativeSystemAdded->AlternativeSystemIDAddedAlternativeSystemReplacement->AlternativeSystemIDReplacementExistingScheduleAffected->ExistingScheduleIDAffectedExistingSystemAffected->ExistingSystemIDAffectedExistingSystemRemoved->ExistingSystemIDRemovedExistingSystemReplaced->ExistingSystemIDReplacedSourceHeatingPlantID->HeatingPlantIDLinkedHeatingPlantID->HeatingPlantIDDeliveryIDs->LinkedDeliveryIDsDeliveryID->LinkedDeliveryIDMakeupAirSourceID->MakeupAirSpaceIDModifiedSchedule->ModifiedScheduleIDModifiedSystem->ModifiedSystemIDReferenceCase->ReferenceScenarioIDUpdate the descriptions of the
IDREFelements to include the valid reference paths as revealed in Docs/generic linking elements #415.Update the xslt translator to include the renaming changes.
Update the examples.
What are the relevant tickets?
#415
#416