Skip to content

Schema modifications for CO2e#436

Merged
laurenliz22 merged 35 commits intodevelop-v2from
ghg-example
Mar 29, 2022
Merged

Schema modifications for CO2e#436
laurenliz22 merged 35 commits intodevelop-v2from
ghg-example

Conversation

@kflemin
Copy link
Copy Markdown
Contributor

@kflemin kflemin commented Mar 7, 2022

Adding CO2e fields.

  1. Added to AllResourceTotal:
    1. AnnualAverageCarbonEmissions
    2. AnnualMarginalCarbonEmissions
  2. Added to ResourceUse -> Emissions -> Emission:
    1. EmissionsLinkedTimeSeriesIDs -> EmissionsLinkedTimeSeriesID
  3. Added to TimeSeries -> TimeSeriesReadingQuantity
    1. Enum "Emissions"
  4. SCENARIO TYPES changes:
    1. Added to ScenarioType -> CurrentBuilding:
      1. Nothing
    2. Added to ScenarioType -> Benchmark:
      1. Nothing
    3. Added to ScenarioType -> Target:
      1. AnnualSavingsAverageCarbonEmissions
      2. AnnualSavingsMarginalCarbonEmissions
    4. Added to ScenarioType -> PackageOfMeasures:
      1. AnnualSavingsAverageCarbonEmissions
      2. AnnualSavingsMarginalCarbonEmissions
      3. Added to ScenarioType -> Other:
        1. AnnualSavingsAverageCarbonEmissions
        2. AnnualSavingsMarginalCarbonEmissions
    5. Added ScenarioType -> DerivedModel :
      1. Nothing

Resolves BuildingSync/project-tracker#94

Comment thread BuildingSync.xsd Outdated
<xs:enumeration value="Frequency"/>
<xs:enumeration value="Power"/>
<xs:enumeration value="Power Factor"/>
<xs:enumeration value="Emissions"/>
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the appropriate value for this enum?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, or maybe Greenhouse Gas Emissions

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GHG Emissions to be consistent if we change the above

@kflemin kflemin added the Schema: Reports Update to reports label Mar 7, 2022
@nllong
Copy link
Copy Markdown
Member

nllong commented Mar 7, 2022

This is great @kflemin, thanks! Can you add a proposal in this folder too? You PR text already has a bunch of the required data. Thanks!

https://github.com/BuildingSync/schema/tree/develop-v2/proposals/2022

@kflemin
Copy link
Copy Markdown
Contributor Author

kflemin commented Mar 8, 2022

@nllong, done!

Copy link
Copy Markdown
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking sweet. Couple comments!

Comment thread BuildingSync.xsd Outdated
Comment thread BuildingSync.xsd Outdated
<xs:element ref="auc:UserDefinedFields" minOccurs="0"/>
<xs:element minOccurs="0" name="AnnualAverageCarbonEmissions">
<xs:annotation>
<xs:documentation>Annual Average Carbon Emissions. (kg CO2e)</xs:documentation>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really a GHG metric since it is CO2e which is each greenhouse gases multipled by global warming potential. So Nitrus Oxide has no carbon, per se, but has a GWP of ~300, so it is more "potent" than 1 kg CO2. Don't make changes yet on the term AnnualAverageCarbonEmissions, let's see what others think.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just name it AnnualAverageGHGEmissions to cover all scenarios? However, if we do this then should we change all (e.g. AnnualSavingsAverageCarbonEmissions to AnnualSavingsAverageGHGEmissions?)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's how it is here: https://github.com/BuildingSync/schema/blob/ghg-example/BuildingSync.xsd#L3108. We could keep that pattern... Let me know if you want that change or if you want to wait.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kflemin let's change it from carbon to GHG throughout. It's more accurate so it makes sense to just include all GHG emissions in addition to carbon, even if they are small.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laurenliz22, done!

Comment thread BuildingSync.xsd Outdated
<xs:enumeration value="Frequency"/>
<xs:enumeration value="Power"/>
<xs:enumeration value="Power Factor"/>
<xs:enumeration value="Emissions"/>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, or maybe Greenhouse Gas Emissions

<Emission>
<EmissionBoundary>Indirect</EmissionBoundary>
<EmissionsType>CO2e</EmissionsType>
<GHGEmissions>TOTAL FROM OUR TIME SERIES</GHGEmissions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update with the real number in the time series

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also made the Greenhouse Gas Emissions change above as well.

Comment thread docs/notebooks/example1-with-sensors.xml Outdated
<SiteEnergyUseIntensity>37.800000</SiteEnergyUseIntensity>
<EnergyCost>4451.510000</EnergyCost>
<EnergyCostIndex>0.810000</EnergyCostIndex>
<AnnualAverageCarbonEmissions>kgCO2e - 10000 </AnnualAverageCarbonEmissions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<AnnualAverageCarbonEmissions>kgCO2e - 10000 </AnnualAverageCarbonEmissions>
<AnnualAverageCarbonEmissions>10000</AnnualAverageCarbonEmissions>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i fixed this in another commit

Comment thread docs/notebooks/example1-with-sensors.xml Outdated
<LinkedTimeSeriesID IDref="POM-LEDs-RU-Electricity-Energy-11"/>
<LinkedTimeSeriesID IDref="POM-LEDs-RU-Electricity-Energy-12"/>
</AnnualFuelUseLinkedTimeSeriesIDs>
<Emissions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

<Emission>
<EmissionBoundary>Indirect</EmissionBoundary>
<EmissionsType>CO2e</EmissionsType>
<GHGEmissions>TOTAL FROM OUR TIME SERIES</GHGEmissions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use total from time series

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

kflemin and others added 4 commits March 11, 2022 16:41
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@laurenliz22 laurenliz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple notes, but looked great to me after reviewing!

Comment thread BuildingSync.xsd Outdated
<xs:enumeration value="Frequency"/>
<xs:enumeration value="Power"/>
<xs:enumeration value="Power Factor"/>
<xs:enumeration value="Emissions"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe GHG Emissions to be consistent if we change the above

Comment thread docs/notebooks/example1-with-sensors.xml
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
Comment thread BuildingSync.xsd Outdated
Comment thread BuildingSync.xsd Outdated
@laurenliz22 laurenliz22 requested a review from markborkum March 22, 2022 14:10
Copy link
Copy Markdown
Contributor

@markborkum markborkum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the auc:EmissionBoundary element have EPA-style "Scope 1", "Scope 2" and "Scope 3" enumerations instead of "Direct" and "Indirect"? ("Scope 1" would map to "Direct". "Scope 2" and "Scope 3" would both map to "Indirect".)

When describing the auc:EmissionsFactor for emissions related to electricity, should there be a way to assert whether grid gross loss (a.k.a "line loss") is included in the calculation?

Comment thread BuildingSync.xsd Outdated
</xs:complexType>
</xs:element>
<xs:element ref="auc:UserDefinedFields" minOccurs="0"/>
<xs:element minOccurs="0" name="AnnualAverageGHGEmissions">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new "GHG" elements should be declared before the auc:UserDefinedFields element.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markborkum, good catch! I just switched the order.

Comment thread docs/notebooks/example1-with-sensors.xml
Comment thread docs/notebooks/example1-with-sensors.xml Outdated
This is what is in the jupyter notebook small office example - I think these 2 files need to line up
Comment thread proposals/2022/Add Emissions.md
@laurenliz22
Copy link
Copy Markdown
Contributor

@markborkum the auc:EmissionBoundary element and the auc:EmissionsFactor for emissions related to electricity were not altered for the GHG Metric updates made to the schema. If we change these then we will cause a breaking change. We are going to add it to our list for future changes regarding GHG Emissions we may need to make that will cause breaking changes. Let me know if you have any questions/concerns. Thanks

Comment thread proposals/2022/Add Emissions.md Outdated
kflemin and others added 2 commits March 29, 2022 14:20
Co-authored-by: Lauren Aronson <48136858+laurenliz22@users.noreply.github.com>
Comment thread proposals/2022/Add Emissions.md Outdated
remove "specifically CO2e"
@laurenliz22 laurenliz22 merged commit 3a2b9b6 into develop-v2 Mar 29, 2022
@laurenliz22 laurenliz22 deleted the ghg-example branch March 29, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3/31/2022] GHG Metrics defined in BuildingSync

5 participants