Schema modifications for CO2e#436
Conversation
| <xs:enumeration value="Frequency"/> | ||
| <xs:enumeration value="Power"/> | ||
| <xs:enumeration value="Power Factor"/> | ||
| <xs:enumeration value="Emissions"/> |
There was a problem hiding this comment.
Is this the appropriate value for this enum?
There was a problem hiding this comment.
I think so, or maybe Greenhouse Gas Emissions
There was a problem hiding this comment.
Maybe GHG Emissions to be consistent if we change the above
|
This is great @kflemin, thanks! Can you add a proposal in this folder too? You PR text already has a bunch of the required data. Thanks! https://github.com/BuildingSync/schema/tree/develop-v2/proposals/2022 |
|
@nllong, done! |
nllong
left a comment
There was a problem hiding this comment.
looking sweet. Couple comments!
| <xs:element ref="auc:UserDefinedFields" minOccurs="0"/> | ||
| <xs:element minOccurs="0" name="AnnualAverageCarbonEmissions"> | ||
| <xs:annotation> | ||
| <xs:documentation>Annual Average Carbon Emissions. (kg CO2e)</xs:documentation> |
There was a problem hiding this comment.
This is really a GHG metric since it is CO2e which is each greenhouse gases multipled by global warming potential. So Nitrus Oxide has no carbon, per se, but has a GWP of ~300, so it is more "potent" than 1 kg CO2. Don't make changes yet on the term AnnualAverageCarbonEmissions, let's see what others think.
There was a problem hiding this comment.
Maybe we just name it AnnualAverageGHGEmissions to cover all scenarios? However, if we do this then should we change all (e.g. AnnualSavingsAverageCarbonEmissions to AnnualSavingsAverageGHGEmissions?)
There was a problem hiding this comment.
that's how it is here: https://github.com/BuildingSync/schema/blob/ghg-example/BuildingSync.xsd#L3108. We could keep that pattern... Let me know if you want that change or if you want to wait.
There was a problem hiding this comment.
@kflemin let's change it from carbon to GHG throughout. It's more accurate so it makes sense to just include all GHG emissions in addition to carbon, even if they are small.
| <xs:enumeration value="Frequency"/> | ||
| <xs:enumeration value="Power"/> | ||
| <xs:enumeration value="Power Factor"/> | ||
| <xs:enumeration value="Emissions"/> |
There was a problem hiding this comment.
I think so, or maybe Greenhouse Gas Emissions
| <Emission> | ||
| <EmissionBoundary>Indirect</EmissionBoundary> | ||
| <EmissionsType>CO2e</EmissionsType> | ||
| <GHGEmissions>TOTAL FROM OUR TIME SERIES</GHGEmissions> |
There was a problem hiding this comment.
update with the real number in the time series
There was a problem hiding this comment.
I also made the Greenhouse Gas Emissions change above as well.
| <SiteEnergyUseIntensity>37.800000</SiteEnergyUseIntensity> | ||
| <EnergyCost>4451.510000</EnergyCost> | ||
| <EnergyCostIndex>0.810000</EnergyCostIndex> | ||
| <AnnualAverageCarbonEmissions>kgCO2e - 10000 </AnnualAverageCarbonEmissions> |
There was a problem hiding this comment.
| <AnnualAverageCarbonEmissions>kgCO2e - 10000 </AnnualAverageCarbonEmissions> | |
| <AnnualAverageCarbonEmissions>10000</AnnualAverageCarbonEmissions> |
There was a problem hiding this comment.
i fixed this in another commit
| <LinkedTimeSeriesID IDref="POM-LEDs-RU-Electricity-Energy-11"/> | ||
| <LinkedTimeSeriesID IDref="POM-LEDs-RU-Electricity-Energy-12"/> | ||
| </AnnualFuelUseLinkedTimeSeriesIDs> | ||
| <Emissions> |
| <Emission> | ||
| <EmissionBoundary>Indirect</EmissionBoundary> | ||
| <EmissionsType>CO2e</EmissionsType> | ||
| <GHGEmissions>TOTAL FROM OUR TIME SERIES</GHGEmissions> |
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
laurenliz22
left a comment
There was a problem hiding this comment.
Added a couple notes, but looked great to me after reviewing!
| <xs:enumeration value="Frequency"/> | ||
| <xs:enumeration value="Power"/> | ||
| <xs:enumeration value="Power Factor"/> | ||
| <xs:enumeration value="Emissions"/> |
There was a problem hiding this comment.
Maybe GHG Emissions to be consistent if we change the above
markborkum
left a comment
There was a problem hiding this comment.
Should the auc:EmissionBoundary element have EPA-style "Scope 1", "Scope 2" and "Scope 3" enumerations instead of "Direct" and "Indirect"? ("Scope 1" would map to "Direct". "Scope 2" and "Scope 3" would both map to "Indirect".)
When describing the auc:EmissionsFactor for emissions related to electricity, should there be a way to assert whether grid gross loss (a.k.a "line loss") is included in the calculation?
| </xs:complexType> | ||
| </xs:element> | ||
| <xs:element ref="auc:UserDefinedFields" minOccurs="0"/> | ||
| <xs:element minOccurs="0" name="AnnualAverageGHGEmissions"> |
There was a problem hiding this comment.
The new "GHG" elements should be declared before the auc:UserDefinedFields element.
There was a problem hiding this comment.
@markborkum, good catch! I just switched the order.
This is what is in the jupyter notebook small office example - I think these 2 files need to line up
|
@markborkum the |
Co-authored-by: Lauren Aronson <48136858+laurenliz22@users.noreply.github.com>
…to an existing field at this point
remove "specifically CO2e"
Adding CO2e fields.
1. Nothing
Resolves BuildingSync/project-tracker#94