Schema: Update notebook#439
Merged
haneslinger merged 23 commits intodevelop-v2from Mar 31, 2022
Merged
Conversation
haneslinger
added
the
Schema: Documentation
Contributor
JieXiong9119
left a comment
JieXiong9119
left a comment
There was a problem hiding this comment.
The codes look good. Do we plan to leave the description part to a new PR or wait for @nllong?
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
laurenliz22
reviewed
Mar 30, 2022
JieXiong9119
previously requested changes
Mar 30, 2022
Contributor
JieXiong9119
left a comment
JieXiong9119
left a comment
There was a problem hiding this comment.
Some modifications suggestions based on validation results and my thoughts.
Member
|
Any reason not to add this to the existing |
Co-authored-by: Lauren Aronson <48136858+laurenliz22@users.noreply.github.com>
Co-authored-by: Lauren Aronson <48136858+laurenliz22@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Co-authored-by: Jie Xiong <69597597+JieXiong9119@users.noreply.github.com>
Contributor
That is what we were not sure about, if it was still appropriate to have in a Level-1 audit. Since it is, we can add it to the current notebook |
Member
Yeah, I would just add it to the existing one. Sorry, I know merging ipynb files is painful! |
laurenliz22
reviewed
Mar 31, 2022
| " bsync.EnergyCost(5395.),\n", | ||
| " bsync.EnergyCostIndex(0.98), # $/ft2\n", | ||
| " ID=\"AllResourceTotal-1\"\n", | ||
| " ),\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " ),\n", |
laurenliz22
reviewed
Mar 31, 2022
| " bsync.EnergyCostIndex(0.98), # $/ft2\n", | ||
| " ID=\"AllResourceTotal-1\"\n", | ||
| " ),\n", | ||
| " bsync.AllResourceTotal(\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " bsync.AllResourceTotal(\n", |
laurenliz22
reviewed
Mar 31, 2022
| " ID=\"AllResourceTotal-1\"\n", | ||
| " ),\n", | ||
| " bsync.AllResourceTotal(\n", | ||
| " bsync.AllResourceTotal.AnnualAverageGHGEmissions(10000.0),\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " bsync.AllResourceTotal.AnnualAverageGHGEmissions(10000.0),\n", |
laurenliz22
reviewed
Mar 31, 2022
| " ),\n", | ||
| " bsync.AllResourceTotal(\n", | ||
| " bsync.AllResourceTotal.AnnualAverageGHGEmissions(10000.0),\n", | ||
| " bsync.AllResourceTotal.AnnualMarginalGHGEmissions(8000.0),\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " bsync.AllResourceTotal.AnnualMarginalGHGEmissions(8000.0),\n", |
laurenliz22
reviewed
Mar 31, 2022
| " bsync.AllResourceTotal(\n", | ||
| " bsync.AllResourceTotal.AnnualAverageGHGEmissions(10000.0),\n", | ||
| " bsync.AllResourceTotal.AnnualMarginalGHGEmissions(8000.0),\n", | ||
| " bsync.AllResourceTotal.AnnualGHGEmissionIntensity(0.123),\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " bsync.AllResourceTotal.AnnualGHGEmissionIntensity(0.123),\n", |
laurenliz22
reviewed
Mar 31, 2022
| " bsync.AllResourceTotal.AnnualAverageGHGEmissions(10000.0),\n", | ||
| " bsync.AllResourceTotal.AnnualMarginalGHGEmissions(8000.0),\n", | ||
| " bsync.AllResourceTotal.AnnualGHGEmissionIntensity(0.123),\n", | ||
| " ID=\"AllResourceTotal-2\"\n", |
Contributor
There was a problem hiding this comment.
Suggested change
| " ID=\"AllResourceTotal-2\"\n", |
haneslinger
dismissed
JieXiong9119’s stale review
he's out, and we're ready to merge. His comments have been addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
What does this PR do?
How should this be manually tested?
What are the relevant tickets?
Screenshots (if appropriate)