Skip to content

update example file and point to develop of bsyncpy#441

Merged
laurenliz22 merged 1 commit intodevelop-v2from
update-example1
Apr 1, 2022
Merged

update example file and point to develop of bsyncpy#441
laurenliz22 merged 1 commit intodevelop-v2from
update-example1

Conversation

@nllong
Copy link
Copy Markdown
Member

@nllong nllong commented Apr 1, 2022

Any background context you want to provide?

Doesn't look like the example1 file was updated with the GHG.

What does this PR do?

  • Update example1.xml
  • Point bsyncpy to develop branch through github, until release that is.
  • bump version of jupyter server for security

How should this be manually tested?

  • poetry install
  • poetry run jupyter lab
  • step through the entire small office notebook

What are the relevant tickets?

n/a

Screenshots (if appropriate)

@nllong nllong requested a review from laurenliz22 April 1, 2022 03:21
@nllong nllong added Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations labels Apr 1, 2022
Copy link
Copy Markdown
Contributor

@laurenliz22 laurenliz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - didn't realize we also included the example 1 xml here since it's generated from the jupyter notebook. Thanks for looking through @nllong !

@laurenliz22 laurenliz22 merged commit f082165 into develop-v2 Apr 1, 2022
@laurenliz22 laurenliz22 deleted the update-example1 branch April 1, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Non-breaking Change Schema: Documentation Update to BuildingSync's documentation/annotations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants