Save notebooks as markdown#443
Merged
nllong merged 2 commits intodevelop-v2from Apr 13, 2022
Merged
Conversation
haneslinger
added
Non-breaking Change
Schema: No Changes
nllong
reviewed
Apr 13, 2022
Member
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
This looks great!
For posterity sake, we need to launch jupyter lab, then open the markdown file with Jupytext Notebook.
I was concerned that outputs were not going to persist in markdown, but it does look like printed results do, which is what we need for this project.
nllong
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
What does this PR do?
We are looking for a better way to handle notebook diffs. Markdowns function just like
.ipynbbut dif better. I would like a way to make the project save all notebooks as markdowns by default but I can't figure out how. that said, simply changing the file extension does the job.I referenced this blog post found by nick.
How should this be manually tested?
What are the relevant tickets?
#106
Screenshots (if appropriate)