Small office prototype building level 2 audit notebook and example#445
Merged
JieXiong9119 merged 6 commits intodevelop-v2from Jun 30, 2022
Merged
Small office prototype building level 2 audit notebook and example#445JieXiong9119 merged 6 commits intodevelop-v2from
JieXiong9119 merged 6 commits intodevelop-v2from
Conversation
First commit. Necessary next steps: 1. Update descriptions and guiding paragraph in between cells for level 2 audit (based on level 1) 2. Update values in fields based on OS simulation (most fields are currently filled with arbitrary number such as 123) 3. Update declaration setting in first cell to set xml attribute declaration heading correctly (now it has to be manually corrected)
JieXiong9119
added
enhancement
DO NOT MERGE
Schema: Documentation
JieXiong9119
changed the title
Map inputs with OS simulation of prototype small office Change location to Denver
Contributor
Author
|
Need to fix declaration header defining part to generate header <BuildingSync xmlns="http://buildingsync.net/schemas/bedes-auc/2019" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://buildingsync.net/schemas/bedes-auc/2019 ../../../BuildingSync.xsd" version="2.4.0"> |
nllong
previously requested changes
Jun 16, 2022
Member
nllong
left a comment
nllong
left a comment
There was a problem hiding this comment.
looking great. few tweaks, but overall fantastic work!
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
laurenliz22
reviewed
Jun 16, 2022
Contributor
laurenliz22
left a comment
laurenliz22
left a comment
There was a problem hiding this comment.
Hey Jie - this looks amazing! I added a couple questions/comments in. one overall question I have is that it looks like our GHG measures are not in here. Sorry if I missed something, but can you remind me if we decided not to start from that version? Thanks! Awesome Job!!
Update some text, fix some tweaks. Still need to make quotes consistent for strings.
Fix quotes inconsistency and some tiny tweaks
Contributor
Author
I believe we decided not to include GHG because it's not required in L1-L3 audit. |
Contributor
Author
|
Merging! (@nllong Nick don't be mad at me for dismissing your change request :P)
|
nllong
removed
DO NOT MERGE
Schema: Documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First commit to create notebook example working on level 2 energy audit on small office prototype building
Next steps:
How should this be manually tested?
Convert the
Small-Office-Level-2.mdinto Jupyter Notebook to edit and run to createexample-level2.xml.What are the relevant tickets?
BuildingSync/project-tracker#85