Update notebooks quotes#448
Conversation
Update all quotes to double quotes to keep consistency
To be consistent with level 2 notebook
JieXiong9119
added
enhancement
Non-breaking Change
Schema: No Changes
|
The validation result image for level 1 example was not updated. The added GHG elements were not updated on the BuildingSync website so the validator gave errors on those elements when validating "example-smalloffice-level1.xml". |
laurenliz22
left a comment
laurenliz22
left a comment
There was a problem hiding this comment.
Hey Jie - saw that "isn't" was changed to "isn"t'. Don't think this was in more than one place, but I can also not view the Level 2 audit for some reason (diff isn't loading). Can you just make sure? Otherwise I think this looks great and is good to go! Thanks for your amazing work here and sorry for my long time in reviewing!
Co-authored-by: Lauren Adams <48136858+laurenliz22@users.noreply.github.com>
Good catch! I modified that and will merge it. |
4 participants
Any background context you want to provide?
We recently update the notebook examples folder to have both level 1 and 2 audits for small office prototype building. This PR follows this up to clean up some left tails.
What does this PR do?
Update notebook examples to have consistent quote usage (double quotes), descriptive text and the outputs.
How should this be manually tested?
Convert the
Small-Office-Level-1.mdandSmall-Office-Level-2.mdinto Jupyter Notebooks to edit and run to create xml outputs.What are the relevant tickets?
BuildingSync/project-tracker#121